Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 360235 - www-plugins/adobe-flash: Invalid USE default "nspluginwrapper"
Summary: www-plugins/adobe-flash: Invalid USE default "nspluginwrapper"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jim Ramsay (lack) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 06:46 UTC by Samuli Suominen (RETIRED)
Modified: 2011-04-01 12:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2011-03-24 06:46:52 UTC
I've selected USE=64bit, and therefore have no use whatsoever for nspluginwrapper. Did you forget to use.mask it in some profile or something?
Comment 1 Fab 2011-03-24 09:47:59 UTC
Also, please mask the nspluginwrapper useflag for 10.2* versions on x86 arch.
Comment 2 Jim Ramsay (lack) (RETIRED) gentoo-dev 2011-03-24 13:05:27 UTC
On amd64 with USE=-32bit, or on x86, was nspluginwrapper actually installed?
Comment 3 Jim Ramsay (lack) (RETIRED) gentoo-dev 2011-03-24 13:16:03 UTC
x86: Done.  Fixed existing package.use.mask so it works properly for *all* versions of adobe-flash.  'nspluginwrapper' will not bother you there.

However, I may go even one more step... tell me what you think of this:

-> If installing a version that only has 32-bit support, *always* install nspluginwrapper on amd64 (IE, remove the USE flag entirely for www-plugins/adobe-flash-10.2.153.1)

-> If installing the 32-bit version on amd64 in an ebuild that supports both, also remove the nspluginwrapper USE flag, but only install nspluginwrapper if there is no 64-bit native plugin installed.

This simplifies things a lot.  I had originally put the nspluginwrapper flag there specifically for amd64 users who would be running a 32-bit plugin in a 32-bit browser (like firefox-bin), and so would not need the wrapper.  But there's probably no harm in just always installing the wrapper anyway as I think the number of 32-bit browser users is pretty small.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-03-27 19:05:23 UTC
(In reply to comment #3)
> -> If installing a version that only has 32-bit support, *always* install
> nspluginwrapper on amd64 (IE, remove the USE flag entirely for
> www-plugins/adobe-flash-10.2.153.1)
> -> If installing the 32-bit version on amd64 in an ebuild that supports both,
> also remove the nspluginwrapper USE flag, but only install nspluginwrapper if
> there is no 64-bit native plugin installed.

That would be ideal.   Please make this happen.
Comment 5 Jim Ramsay (lack) (RETIRED) gentoo-dev 2011-03-28 12:58:30 UTC
Done.  Removed the 'nspluginwrapper' USE flag, and adjusted the DEPEND logic so it "always" does the right thing.
Comment 6 Pekka Paalanen 2011-04-01 12:41:34 UTC
Has the nspluginwrapper suddenly become stable now with adobe-flash?
The nspluginwrapper ebuild still warns about instability.

The current state is (I updated my system today) that nspluginwrapper is installed automatically with a 32-bit-only adobe-flash on amd64. Hence, adobe-flash is immediately enabled in Firefox. Without flashblock (which is not installed automatically, to my knowledge) Flash would execute.

Being curious, I tried a Youtube flash video. That lead to graphics corruption of the desktop, not limited to any specific windows. My guess based on the symptoms is that adobe-flash managed to use a video overlay of the proprietary Nvidia driver, but the overlay was not shut down properly, and still affects rendering, especially AA fonts. The USE flag "vdpau" is off. Also the video seemed a little corrupted.

You can of course think of this as me shooting my own foot - why would I install 32-bit adobe-flash with a 64-bit firefox, when I do not expect it to function at all? At one time, adobe-flash provided a 64-bit plugin, and the package has been installed on my system ever since. Apparently there once were 32bit and 64bit USE flags, but equery does not list them anymore, nor have I set either. There are also rumors, that a new 64-bit plugin is coming. Up to now, I have been relying on not having nspluginwrapper installed.

Do I really have to play catch with the 64-bit plugin, and manually install adobe-flash.ebuild when 64-bit support comes, and manually uninstall adobe-flash.ebuild when 64-bit support is removed due to open security issues?
Or could you perhaps either add USE flags for forcing the plugin arch, or split the package to explicitly 32-bit and 64-bit ebuilds?

Then again, you can blame me for having a useless package (which now became harmful) installed.
I'll go and remove adobe-flash and nspluginwrapper now to fix my desktop.