356563 – gnome-extra/gcalctool-5.32.2 compile problem

Bug 356563 - gnome-extra/gcalctool-5.32.2 compile problem

Summary: gnome-extra/gcalctool-5.32.2 compile problem

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GNOME (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-26 11:49 UTC by pp--
Modified:	2011-09-11 09:12 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
fixed ebuild (gcalctool-5.32.2.1.ebuild,1003 bytes, text/plain) 2011-02-26 11:51 UTC, pp--	Details
fixed anyway (gcalctool-5.32.2.ebuild,1003 bytes, text/plain) 2011-02-26 11:56 UTC, pp--	Details
The build error log. (gnome-extra:gcalctool-5.32.2:20110831-203257.log,14.40 KB, text/plain) 2011-08-31 20:38 UTC, Balint SZENTE	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description pp-- 2011-02-26 11:49:31 UTC

Missing locale.h header in gcalctool.c

Reproducible: Always

Comment 1 pp-- 2011-02-26 11:51:21 UTC

Created attachment 263901 [details]
fixed ebuild

Comment 2 pp-- 2011-02-26 11:56:08 UTC

Created attachment 263903 [details]
fixed anyway

Comment 3 Christian Ruppert (idl0r) gentoo-dev

2011-02-26 12:13:09 UTC

Please use the right Product next time.

Comment 4 Christian Ruppert (idl0r) gentoo-dev

2011-02-26 12:13:41 UTC

Reopen for changing assignee

Comment 5 Christian Ruppert (idl0r) gentoo-dev

2011-02-26 12:15:33 UTC

I'll close it as INVALID instead of FIXED as it seems to be a problem on your site, interpreted by your bug changes.

Comment 6 Bradley Broom 2011-07-05 19:01:56 UTC

I get exactly the same compile error, and it looks like the attached patch would fix it.

What exactly do you mean by a "problem on your site"?

I've had gentoo installed on my machines for years, on this machine specifically since April 2007, and not encountered this problem before.

I've searched a lot for gentoo and LC_ALL and found many messages claiming the non-inclusion of locale.h is the problem, but not found anything that identifies a specific "problem with my site" or even identifies a list of things to look at.

Comment 7 Balint SZENTE 2011-08-30 21:55:07 UTC

Same error here on x86-64.

This is a very legitimate bug! That include file is really missing from gcalctool.c, actually in 5.91.0 is fixed already. So the ebuild must be changed or the gcalctool version must be bumped.

Please reopen the ticket.

Comment 8 Balint SZENTE 2011-08-30 22:22:52 UTC

Bumping the version by renaming the ebuild to 5.91.93 is enough. Several bugs were fixed.

Comment 9 Pacho Ramos gentoo-dev

2011-08-31 08:32:48 UTC

Please attach full build.log when it fails

Comment 10 Balint SZENTE 2011-08-31 20:35:57 UTC

In my case, the build error appears with optimisation level less then 1.

So if I have in make.conf:
CFLAGS="-march=native -pipe"
or
CFLAGS="-march=native -pipe -O0"
the build error appears (see the attached log). The MAKEOPTS variable does not matter.

The problem can be solved with the following 3 possibilities:
 1. adding the "-O1" or "-O2" option to the CFLAGS;
 2. adding the missing #include <locale.h>;
 3. bumping to 5.91.93.

In my option the last variant is the best, because it builds correctly and it has a lot of enhancements and bug fixes.

Comment 11 Balint SZENTE 2011-08-31 20:38:40 UTC

Created attachment 285185 [details]
The build error log.

The build error log with CFLAGS="-march=native -mno-avx -pipe".

Comment 12 Pacho Ramos gentoo-dev

2011-09-11 09:12:04 UTC

+  11 Sep 2011; Pacho Ramos <pacho@gentoo.org> gcalctool-5.32.2.ebuild,
+  +files/gcalctool-5.32.2-missing-header.patch:
+  Fix compilation problems due missing header, bug #356563 by pp--, Bradley
+  Broom and Balint SZENTE.
+