Probably while adding otool to detect if Esetroot is build against libImlib, a bash-ism made it into fbsetbg. This makes it e.g. fail to detect Esetroot, when /bin/sh is linked to /bin/dash. I'll attach a little patch for review. Reproducible: Always Steps to Reproduce: 1. ln -sf /bin/dash /bin/sh 2. start fluxbox 3. set a wallpaper with fbsetbg 4. notice that all the fancy is gone as 'display' is used instead of Esetroot Actual Results: User gets sad :'-( Expected Results: User gets happy :-)
Created attachment 262729 [details, diff] more posix compliances This works fine for me atleast.
Created attachment 263637 [details, diff] Posix-compliant fluxbox-1.1.1-osx-has-otool.patch Thanks for the report. This posix issue is due to a patch added by the prefix team for OSX support. This attachment *should* be the equivalent patch, though I have no way of testing it here with no OSX box of my own. I'll notify the prefix folks to take a look at this bug to verify this works.
@Prefix team: See comment above where I added an attachment... Please verify that this replacement for the existing 'fluxbox-1.1.1.1-osx-has-otool.patch' actually does what it's supposed to do on OSX.
Looking at the (original) patch, I have the impression it's too careful. elif ldd `which Esetroot`|grep libImlib 2>&1 > /dev/null || \ otool -L `which Esetroot`|grep libImlib 2>&1 > /dev/null ; then should do too, IFAICT. Either of ldd or otool should exist and think that whatever which Esetroot returns is valid, and then grep has to like it. Or am I overlooking something obvious here?
(In reply to comment #4) > IFAICT. Either of ldd or otool should exist and think that > whatever which Esetroot returns is valid, and then grep has to like it. > > Or am I overlooking something obvious here? As far as I understand the intent of the script, what you say seems reasonable. However, I don't have any way to test it.
if it works for you, commit it
Yes, works for me. Committed. I didn't revbump for it, but it's in all fluxbox-1.1.1-r* and fluxbox-1.3.*
