353859 – >=media-plugins/audacious-plugins-2.4: automagic x11-libs/libnotify depend

Bug 353859 - >=media-plugins/audacious-plugins-2.4: automagic x11-libs/libnotify depend

Summary: >=media-plugins/audacious-plugins-2.4: automagic x11-libs/libnotify depend

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Tony Vroon (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-06 14:20 UTC by iGentoo
Modified:	2011-02-06 17:48 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
ebuild diff (audacious-plugins-2.5_alpha1.ebuild.diff,1.70 KB, patch) 2011-02-06 14:22 UTC, iGentoo	Details \| Diff
This is a patch. (audacious-plugins-2.5_alpha1-libnotify-0.7.0.patch,1.29 KB, patch) 2011-02-06 14:23 UTC, iGentoo	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description iGentoo 2011-02-06 14:20:50 UTC

libnotify     : Enable desktop notification support.

Reproducible: Always

Comment 1 iGentoo 2011-02-06 14:22:45 UTC

Created attachment 261644 [details, diff]
ebuild diff

Comment 2 iGentoo 2011-02-06 14:23:45 UTC

Created attachment 261646 [details, diff]
This is a patch.

Comment 3 Rafał Mużyło 2011-02-06 16:57:13 UTC

Support for libnotify 0.7 series is a bug for upstream.
(Yet another) automagical dep *is* a Gentoo bug.
(Once again) the configure option is already present, ebuild just doesn't use it.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2011-02-06 17:21:42 UTC

Comment on attachment 261646 [details, diff]
This is a patch.

I've applied better patch in CVS to both 2.4.3-r1 and 2.5_alpha1.   It doesn't meddle with configure* at all since it's not necessary.

Tony, please commit/forward it to upstream.

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2011-02-06 17:22:47 UTC

The USE flag and depend is still missing so leaving the bug open.

Comment 6 Tony Vroon (RETIRED) gentoo-dev

2011-02-06 17:31:57 UTC

(In reply to comment #4)
> I've applied better patch in CVS to both 2.4.3-r1 and 2.5_alpha1.   It doesn't
> meddle with configure* at all since it's not necessary.
> Tony, please commit/forward it to upstream.

Done now, thank you:
<CIA-1> audacious-plugins: Tony Vroon <chainsaw@gentoo.org> default * 5355:d7f4e82ea5ff /src/notify/libnotify-aosd_osd.c: notify: Allow building against libnotify 0.7; patch by Samuli Suominen of Gentoo Linux.

Comment 7 Samuli Suominen (RETIRED) gentoo-dev

2011-02-06 17:48:34 UTC

(In reply to comment #5)
> The USE flag and depend is still missing so leaving the bug open.
> 

fixed that too, thanks Alphat-PC!