Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 353679 - app-misc/mc-4.7.5 unnecessary REQUIRED_USE
Summary: app-misc/mc-4.7.5 unnecessary REQUIRED_USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Alex Alexander (RETIRED)
URL:
Whiteboard:
Keywords:
: 484384 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-04 11:57 UTC by Ulrich Müller
Modified: 2013-09-10 14:17 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2011-02-04 11:57:28 UTC
mc-4.7.5 adds an ncurses flag, together with REQUIRED_USE="^^ ( ncurses slang )". However, ncurses will be pulled in any case, as it's a dependency of slang. And as the two flags can't be used together, it doesn't add any additional choice for the user.

IMHO this is an example where REQUIRED_USE should _not_ be used. I'd suggest that the ebuild returns to the solution used in previous versions, with only a slang flag.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2011-02-04 12:13:05 UTC
+1. I already pointed this out yesterday'ish. 
Comment 2 Alex Alexander (RETIRED) gentoo-dev 2011-02-04 13:41:22 UTC
The use flags select one of the two screen implementations. yes, it doesn't reflect the deps, but it reflects what is actually used.

I think this is much clearer for the user, if however everyone else thinks it is bad I'll revert it :)
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2011-02-04 14:34:16 UTC
I think required use is quite good in this area.

Altho i might go with:

^^ ( ncurses slang )
Comment 4 Robert Piasek (RETIRED) gentoo-dev 2011-02-28 21:39:56 UTC
personally I find it more confusing. +1 to the old way
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2012-03-20 20:03:26 UTC
Agreed. Having one switch is good enough to pick one from two avilable options.

Pushed as:

> *mc-4.8.2 (20 Mar 2012)
>
> Version bump. Don't require user to choose from ncurses/slang (bug #353679 by
> Ulrich Müller and others); use slang by default as less buggy implementation.
> New release among others fixes crash when ~/.config is not a dir (bug #406315
> by Marcin Mirosław).

Added local desc. for USE=slang as well:
> <flag name="slang">Use <pkg>sys-libs/slang</pkg> instead of <pkg>sys-libs/ncurses</pkg>.</flag>

Thanks guys!
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2013-09-10 14:17:42 UTC
*** Bug 484384 has been marked as a duplicate of this bug. ***