Bugzilla Bug 35167

As part of the build process for openglad-0.98, it uses the gladpack utility to
compress the pictures and scenery files.  This works correctly, but make fails
with "Error 63" and "Error 33" respectively.

A look at the util/gladpack.c shows that the calls to pack() and unpack() in
main() do not set the return value.  Changing the calls to "return pack(...)"
and "return unpack(...)" fix this problem.

(A patch doing exactly this will follow shortly.)

Reproducible: Always
Steps to Reproduce:
1. emerge openglad


Actual Results:  
[snip]

make[1]: Entering directory `/var/tmp/portage/openglad-0.98/work/openglad-0.98'
cd pix; ../util/gladpack p ../graphics.001 *.pix
Creating packfile ../graphics.001...
cd scen; ../util/gladpack p ../levels.001 *.fss
Creating packfile ../levels.001...
make[1]: *** [levels.001] Error 63
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [graphics.001] Error 33
make[1]: Leaving directory `/var/tmp/portage/openglad-0.98/work/openglad-0.98'
make: *** [all-recursive] Error 1

!!! ERROR: games-rpg/openglad-0.98 failed.
!!! Function src_compile, Line 22, Exitcode 2
!!! emake failed



"emerge info" details:

Portage 2.0.49-r18 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r9,
2.6.0-test11-gentoo-r1)
=================================================================
System uname: 2.6.0-test11-gentoo-r1 i686 AMD Athlon(tm) XP 1800+
Gentoo Base System version 1.4.3.12
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -Os -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3/share/config /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=athlon-xp -Os -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://public.planetmirror.com/pub/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X aalib alsa apm arts avi berkdb cdr crypt cups encode esd foomatic-db
foomaticdb gdbm gif gpm gtk gtk2 imlib java jpeg kde libg++ libwww mad mikmod
mmx motif mozilla mpeg ncurses nls oggvorbis opengl oss pam pdflib perl png ppds
python qt quicktime readline sdl slang spell sse ssl svga tcpd truetype x86 xml2
xmms xv zlib"

Created an attachment (id=21775) [edit]
Suggested patch for util/gladpack.c

added to cvs, thanks