Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 350730 - Stabilize app-crypt/johntheripper-1.7.6-r1
Summary: Stabilize app-crypt/johntheripper-1.7.6-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Crypto team [DISABLED]
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2011-01-05 18:18 UTC by Dane Smith (RETIRED)
Modified: 2011-02-08 15:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-crypt:johntheripper-1.7.6-r1:20110202-054502.log [hppa,fail] (20110202-054502.log,8.26 KB, text/plain)
2011-02-02 06:15 UTC, Jeroen Roovers (RETIRED)
Details
patch to write to a config.gentoo instead of escaping either too much or not enough (johntheripper-1.7.6-r1.ebuild.patch,945 bytes, patch)
2011-02-07 20:01 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dane Smith (RETIRED) gentoo-dev 2011-01-05 18:18:03 UTC
As per $summary!

Arches: note bug 327211 should only apply to PPC/PPC64.

PPC devs, how do we want to address bug 327211?

Thanks!
Comment 1 Matt Turner gentoo-dev 2011-01-05 18:53:38 UTC
No stable keywords for mips.
Comment 2 Agostino Sarubbo gentoo-dev 2011-01-05 19:16:17 UTC
amd64 ok
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2011-01-05 19:16:46 UTC
ppc/ppc64 will skip because of bug 327211, i've dropped stable keywording so
you can remove the old version.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2011-01-05 19:29:58 UTC
amd64 done. Thanks Agostino
Comment 5 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-01-06 20:56:32 UTC
x86 stable
Comment 6 Raúl Porcel (RETIRED) gentoo-dev 2011-01-29 13:34:19 UTC
alpha/sparc stable
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2011-02-02 06:15:25 UTC
Created attachment 261312 [details]
app-crypt:johntheripper-1.7.6-r1:20110202-054502.log [hppa,fail]

On HPPA, due to unknown circumstances, I get

<command-line>: warning: missing terminating " character
<command-line>: warning: missing terminating " character
path.c: In function ‘path_init’:
path.c:40: error: stray ‘\’ in program
path.c:40: error: missing terminating " character
distcc[4776] ERROR: compile path.c on localhost failed

after quite a lot of these:
<command-line>: warning: missing terminating " character

I checked if it built without distcc, and it didn't. I then looked at the ebuild, saw that the definitions -DJOHN_SYSTEMWIDE_HOME=\\\"/etc/john\\\" and -DJOHN_SYSTEMWIDE_EXEC=\\\"/usr/libexec/john\\\" were now properly quoted in single quotation marks, and tried without the extra two escapes on each side of the expressions, and that worked fine, so I am committing that change too.

Index: johntheripper-1.7.6-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-crypt/johntheripper/johntheripper-1.7.6-r1.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 johntheripper-1.7.6-r1.ebuild
--- johntheripper-1.7.6-r1.ebuild       29 Jan 2011 13:34:48 -0000      1.5
+++ johntheripper-1.7.6-r1.ebuild       2 Feb 2011 06:12:45 -0000
@@ -22,7 +22,7 @@
 LICENSE="GPL-2"
 SLOT="0"
 # This package can't be marked stable for ppc or ppc64 before bug 327211 is closed.
-KEYWORDS="alpha amd64 ~hppa ~mips ~ppc ~ppc64 sparc x86"
+KEYWORDS="alpha amd64 hppa ~mips ~ppc ~ppc64 sparc x86"
 IUSE="altivec custom-cflags -minimal mmx openmp sse2"
 #IUSE="altivec custom-cflags -minimal mmx -mpi sse2"
 
@@ -95,8 +95,8 @@
        use custom-cflags || strip-flags
        append-flags -fPIC -fPIE \
                '-DJOHN_SYSTEMWIDE' \
-               '-DJOHN_SYSTEMWIDE_HOME=\\\"/etc/john\\\"' \
-               '-DJOHN_SYSTEMWIDE_EXEC=\\\"/usr/libexec/john\\\"'
+               '-DJOHN_SYSTEMWIDE_HOME=\"/etc/john\"' \
+               '-DJOHN_SYSTEMWIDE_EXEC=\"/usr/libexec/john\"'
        gcc-specs-pie && append-ldflags -nopie
        use openmp && OMP="-fopenmp"

Wed Feb  2 07:14:35 CET 2011
Portage 2.1.9.35 (default/linux/hppa/10.0, gcc-4.4.4, glibc-2.11.2-r3, 2.6.36-gentoo-r5-JeR parisc)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.36-gentoo-r5-JeR-parisc-PA8700_-PCX-W2-with-gentoo-2.0.1
Timestamp of tree: Wed, 02 Feb 2011 04:45:01 +0000
distcc 3.1 hppa2.0-unknown-linux-gnu [enabled]
ccache version 2.4 [disabled]
app-shells/bash:     4.1_p9
dev-lang/python:     2.6.6-r1, 3.1.3
dev-util/ccache:     2.4-r9
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1-r1
sys-apps/openrc:     0.7.0
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.13, 2.65-r1
sys-devel/automake:  1.4_p6-r1, 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.4-r2, 4.5.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.30-r1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="hppa"
ACCEPT_LICENSE="* -@EULA"
CBUILD="hppa2.0-unknown-linux-gnu"
CFLAGS="-mschedule=8000 -march=2.0 -pipe -Wall -O2"
CHOST="hppa2.0-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib/distcc/bin /var/bind /var/spool/torque /var/www/localhost/htdocs/wordpress/wp-config.php"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.2/ext-active/ /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.2/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.2/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-mschedule=8000 -march=2.0 -pipe -Wall -O2"
DISTDIR="/aches/distfiles"
FEATURES="assume-digests binpkg-logs buildpkg distcc distlocks fixlafiles fixpackages news notitles parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv"
FFLAGS="-mschedule=8000 -march=2.0 -pipe -Wall -O2"
GENTOO_MIRRORS="http://de-mirror.org/distro/gentoo/ http://mirror.netcologne.de/gentoo/ http://ftp.snt.utwente.nl/pub/os/linux/gentoo http://gentoo.tiscali.nl/ "
LC_ALL="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed"
LINGUAS="en nl he"
MAKEOPTS="-j6"
PKGDIR="/keeps/gentoo/packages/elmer"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/dev/shm/"
PORTDIR="/keeps/gentoo/portage"
PORTDIR_OVERLAY="/keeps/gentoo/local"
SYNC="rsync://rsync.nl.gentoo.org/gentoo-portage"
USE="7zip X Xaw3d a52 aac aalib abyss accessibility acl ads agg alsa amr amrnb amrwb ao aoss apis ares artist-screen asf ass assistant async asyncns audiofile audit automount avfs bash-completion berkdb bidi bittorrent bittorrent-external bl bluetooth bzip2 c++ cairo caps captury catalogs cblas cdb cddb cdparanoia cdr chardet cjk clarens cleartype cli colors contrast cpath cracklib crypt cups curl custom-cflags custom-cxxflags cxx dbi dbtool dbus designer designer-plugin device-mapper dga dia dirac directfb djbfft djvu domainkeys dri drm dts dv dvd dvdr dvdread ebook edl elf emacs enca encode esd examples exceptions exif expat facebook facedetect fame fastbuild fastcgi fbcon ffmpeg filter fits flac fluidsynth fontconfig foomaticdb fortran fpx frei0r ftp fts3 gadu galago games gcrypt gd gdbm geant4 geoip ggi gif gimp gimpprint glep glib glut gmp gnokii gnutls gphoto2 gpm gps graphite gs gsl gsm gtk gtk2 gtkhtml guidexml guile hal hepmc hesiod hotpixels hppa i18n ical icecast iconv icu idea idn imagemagick imlib indi inquisitio ipv6 isc ithreads jabber jack javascript jbig jingle jpeg jpeg2k judy kpathsea lapack lasi latex lcms ldap leim lensfun libass libcaca libffi libmms libotf libsamplerate libwww live logrotate logwatch lto lua lyrics-screen lzma lzo mad manhole matroska mbrola mem-scramble memcache metis mhash midi mikmod mmap mng modplug modules motif mozbranding mp3 mpi mplayer mssql mudflap multislot musepack musicbrainz mysql nagios-dns nagios-game nagios-ntp nagios-ping nagios-ssh nas ncurses netpbm network-cron nfconntrack nfs nls nntp nova nptl nptlonly nsplugin ntlm objc objc++ objc-gc offensive ogg openal openexr opengl openmp openssl optimization oss ots overlays pam pango pbs pch pcre pdf pdo-external perl php plasma plotutils plugins png policykit portage portaudio postgres povray ppds pppd pulseaudio python pyzord qalculate qdbm qt3support qt4 quotas raw readline recode rle romio rpc rrdtool rtc rtmp ruby ruby18 samba sasl scale0tilt scanner scim sdl seamonkey secure-delete server session sid skk slang slp smi sms sndfile snmp soap song-screen soundex speex spell spoof-source sqlite srt srtp ssh ssl startup-notification strong-optimization subtitles subversion suhosin supernodal svg swat sysfs syslog system-sqlite talkfilters tcl tcpd test tftp tga theora threads thumbnail thunar-vfs tidy tiff timezone timidity tk tokyocabinet tools truetype tslib tunepimp twolame udev unicode unzip urandom usb userlocales utempter utf v4l v4l2 vanim vcd vidix vim-syntax vorbis watchdog wavpack webdav webinstall wildmidi winbind wlan wma wmf xanim xattr xcb xchattext xcomposite xface xlisten xml xml2 xmp xmpi xorg xpm xrandr xscreensaver xsettings xulrunner xv xvid xvmc zip zip-external zlib" ALSA_CARDS="ad1889 usb-audio" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_ftp proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias asis authn_alias cern_meta charset_lite dumpio log_forensic substitute version" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev joystick keyboard mouse acecad aiptek calcomp citron digitaledge dmc dynapro elo2300 elographics fpit hyperpen jamstudio magellan microtouch mutouch palmax penmount spaceorb summa tek4957 tslib ur98 wacom void" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en nl he" PHP_TARGETS="php5-2 php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="stifb fbdev none dummy" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

app-crypt/johntheripper-1.7.6-r1 was built with the following:
USE="custom-cflags openmp test (-altivec) -minimal (-mmx) (-sse2)"
CFLAGS="-mschedule=8000 -march=2.0 -pipe -Wall -O2 -fPIC -fPIE -DJOHN_SYSTEMWIDE -DJOHN_SYSTEMWIDE_HOME=\"/etc/john\" -DJOHN_SYSTEMWIDE_EXEC=\"/usr/libexec/john\""
CXXFLAGS="-mschedule=8000 -march=2.0 -pipe -Wall -O2 -fPIC -fPIE -DJOHN_SYSTEMWIDE -DJOHN_SYSTEMWIDE_HOME=\"/etc/john\" -DJOHN_SYSTEMWIDE_EXEC=\"/usr/libexec/john\""
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2011-02-02 06:18:15 UTC
Stable for HPPA and closing.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2011-02-07 20:01:40 UTC
Created attachment 261753 [details, diff]
patch to write to a config.gentoo instead of escaping either too much or not enough
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2011-02-07 20:02:34 UTC
Reopening after private discussion about a possibly bad commit (cvs rev 1.7).
Comment 11 Dane Smith (RETIRED) gentoo-dev 2011-02-08 12:47:12 UTC
I had reverted the changes in question yesterday. (But not the hppa keyword). John is now back to ~hppa as of just now.. I will look into your patch. When I get it working on x86 / amd64, I will readd hppa to CC. Thanks Jeroen!
Comment 12 Dane Smith (RETIRED) gentoo-dev 2011-02-08 13:35:41 UTC
(In reply to comment #9)
> Created an attachment (id=261753) [details]
> patch to write to a config.gentoo instead of escaping either too much or not
> enough
> 

This is in CVS as of now. HPPA should be able to proceed with stabilization now. Thanks Jeroen!
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2011-02-08 15:12:28 UTC
Stable for HPPA again.