Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 350129 - app-shells/zsh-completion should drop _eix for >=app-portage/eix-0.22.6[zsh-completion]
Summary: app-shells/zsh-completion should drop _eix for >=app-portage/eix-0.22.6[zsh-c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Dawid Węgliński (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 08:02 UTC by Martin Väth
Modified: 2011-01-05 18:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for renaming (zsh-completion.ebuild.patch,206 bytes, patch)
2011-01-03 08:15 UTC, Martin Väth
Details | Diff
Patch for deleting and blocking (zsh-completion.ebuild.patch,778 bytes, patch)
2011-01-03 08:19 UTC, Martin Väth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2010-12-30 08:02:36 UTC
Since >=app-portage/eix-0.22.6 optional support for zsh-completion is
provided by eix upstream which will collide with
<=app-shells/zsh-completion-20091203 in /usr/share/zsh/site-functions/_eix.
It would be nice if >=app-portage/eix-0.22.6[zsh-completion] could install
that file.
So I suggest that this file be dropped (or renamed to something later in
alphabet) by app-shells/zsh-completion with perhaps blocks for older
versions be introduced.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-03 02:35:20 UTC
Martin, Do you have a patch ready for this package?
Comment 2 Martin Väth 2011-01-03 08:15:21 UTC
Created attachment 258716 [details, diff]
Patch for renaming

Depends on whether you prefer renaming or deleting and blocking.
Comment 3 Martin Väth 2011-01-03 08:19:37 UTC
Created attachment 258717 [details, diff]
Patch for deleting and blocking
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-04 04:40:36 UTC
+*zsh-completion-20091203-r1 (04 Jan 2011)
+
+  04 Jan 2011; Jeremy Olexa <darkside@gentoo.org>
+  +zsh-completion-20091203-r1.ebuild:
+  revision bump to remove eix completion and block older eix versions to
+  prevent file collisions, bug 350129

Sorry, forgot to credit you Martin, thanks.
Comment 5 Michael Weber (RETIRED) gentoo-dev 2011-01-05 02:04:38 UTC
Hi,

can you please add an blocker for <app-shells/zsh-completion-20091203-r1 to eix-0.22.6.

I know, stable/unstable mixup, but it's annoying.

Michael
Comment 6 Kaleb Elwert (belak) 2011-01-05 02:06:24 UTC
(In reply to comment #4)
> +*zsh-completion-20091203-r1 (04 Jan 2011)
> +
> +  04 Jan 2011; Jeremy Olexa <darkside@gentoo.org>
> +  +zsh-completion-20091203-r1.ebuild:
> +  revision bump to remove eix completion and block older eix versions to
> +  prevent file collisions, bug 350129
> 
> Sorry, forgot to credit you Martin, thanks.
> 

Broke the update for zsh-completion and eix-0.22.6

I think eix should conflict with <zsh-completion-20091203-r1 and should depend
on >=zsh-completion-20091203-r1 (if the zsh-completion use flag is enabled).
Also the zsh-completion ebuild should not conflict with >=eix-0.22.6 or else,
zsh-completion would not be upgraded before eix and there will be file
conflicts.

Whatever happens, however it's done, the zsh-completion package needs to update
before eix.
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-05 03:00:41 UTC
(In reply to comment #5)

> I know, stable/unstable mixup, but it's annoying.

Actually, it's not.

(In reply to comment #6)

> Whatever happens, however it's done, the zsh-completion package needs to update
> before eix.

Yea, I think >=app-shells/zsh-completion-20091203-r1 is proper here instead of a blocker then. Good point.

+  05 Jan 2011; Jeremy Olexa <darkside@gentoo.org> eix-0.22.6.ebuild:
+  specify zsh-completion version needed for upgrade path, bug 350129
Comment 8 Martin Väth 2011-01-05 15:45:07 UTC
I am not sure whether this is the best solution:

Altough probably most people with USE=zsh-completion will also want
to emerge app-shells/zsh-completion, this is not a required dependency
of eix[zsh-completion], and so perhaps nobody should be forced.
I think a cross-block (in eix
  zsh-completion? ( !<app-shells/zsh-completion-20091203-r1 )
and the existing block in app-shells/zsh-completion-20091203-r1)
should be sufficient.
Comment 9 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-05 15:55:10 UTC
Ok, I made that change, Martin. I'm not a zsh user and my knowledge of zsh-completion isn't superb, thanks :)
Comment 10 Martin Väth 2011-01-05 15:56:52 UTC
(In reply to comment #8)
> I think a cross-block

Sorry, this was stupid, as it might break the upgrade path
(for a cross-block only eix and zsh-completion can be upgraded simultaneously,
but we cannot guarantee that zsh-completion is upgraded before eix).
It is probably better to add the block only to eix-0.22.6 and remove
the block from zsh-completion.
This way, people upgrading _only_ zsh-completion might loose their support
for eix completion, but this is only a temporary problem since it will come
back once they upgrade eix. (I guess this is not a serious problem since
there is a corresponding comment in the ChangeLog of zsh-completion, so they
can look it up if they should really desire completion for eix urgently.)
Comment 11 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-05 16:03:39 UTC
> but we cannot guarantee that zsh-completion is upgraded before eix).

That was the problem that I intially solved by making eix require >=zsh-comp, as you pointed out...it is not a requirement for eix so the !< block would be appropriate.

Now, zsh-completion still needs some block on eix, else there will be a file collision. However, it is hard to figure out all the issues when people are mixing arch/~arch...



Comment 12 Martin Väth 2011-01-05 17:16:05 UTC
(In reply to comment #11)
> Now, zsh-completion still needs some block on eix, else there will be a file
> collision.

I do not think so if the blocker in eix[zsh-completion] is strict
(with two exclamation marks):

  zsh-completion? ( !!<app-shells/zsh-completion-20091203-r1 )

If I understand pms correctly, this will guarantee that
<app-shells/zsh-completion-20091203-r1 and
app-portage/eix[zsh-completion]
can _never_ be installed at the same time and so no file collision can occur.
Comment 13 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-05 18:01:12 UTC
Alright, what you said makes sense. This became quite messy, sorry all.

I just made it an !!<zsh-comp block in eix and removed the !<eix block in zsh-completion. I hope that works for everyone.