Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349160 - media-gfx/gthumb-2.12.1 incompatible with media-gfx/exiv2-0.21 due to API changes
Summary: media-gfx/gthumb-2.12.1 incompatible with media-gfx/exiv2-0.21 due to API cha...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2010-12-20 03:46 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2010-12-21 15:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gthumb-2.12.1-exiv2-0.21.patch (gthumb-2.12.1-exiv2-0.21.patch,2.38 KB, patch)
2010-12-20 03:50 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2010-12-20 03:46:53 UTC
Due to API changes in recently released media-gfx/exiv2-0.21 (see http://dev.exiv2.org/issues/show/0000721), gthumb-2.12.1 with USE=exif (as well as upstream gthumb git head) fails to build:

# USE=exif emerge gthumb
[...]
make[4]: Entering directory `/var/tmp/portage/media-gfx/gthumb-2.12.1/work/gthumb-2.12.1/extensions/exiv2_tools'
  CXX    libexiv2_tools_la-exiv2-utils.lo
exiv2-utils.cpp: In function ‘const char* get_exif_default_category(const Exiv2::Exifdatum&)’:
exiv2-utils.cpp:500:6: error: ‘isMakerIfd’ is not a member of ‘Exiv2::ExifTags’
exiv2-utils.cpp:504:7: error: ‘ifd1Id’ is not a member of ‘Exiv2’
exiv2-utils.cpp:506:7: error: ‘gpsIfdId’ is not a member of ‘Exiv2’
exiv2-utils.cpp:508:7: error: ‘iopIfdId’ is not a member of ‘Exiv2’
exiv2-utils.cpp: In function ‘void exiv2_read_metadata(Exiv2::Image::AutoPtr, GFileInfo*)’:
exiv2-utils.cpp:534:28: error: ‘ifd1Id’ is not a member of ‘Exiv2’
make[4]: *** [libexiv2_tools_la-exiv2-utils.lo] Error 1
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2010-12-20 03:50:49 UTC
Created attachment 257596 [details, diff]
gthumb-2.12.1-exiv2-0.21.patch

Patch for exiv-0.21 compatibility; should allow compilation with exiv-0.20 as well as 0.21. Tested with exiv-0.21 on many photos, works fine.

I am also submitting this patch upstream at https://bugzilla.gnome.org/show_bug.cgi?id=636227
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-12-20 09:48:14 UTC
I suppose exiv2 upstream didn't consider slotting their lib right ?
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2010-12-20 17:05:12 UTC
The patch has been accepted by gthumb upstream: http://git.gnome.org/browse/gthumb/commit/?id=1834cea61050e476e97e3831538169a40af8a72f
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2010-12-21 14:55:02 UTC
+  21 Dec 2010; Samuli Suominen <ssuominen@gentoo.org> gthumb-2.12.1.ebuild,
+  +files/gthumb-2.12.1-new-exiv2.patch:
+  Fix compability with exiv2 >= 0.21 API wrt #349160 by Alexandre Rostovtsev.