Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 348600 - www-client/chromium uses bundled libsrtp
Summary: www-client/chromium uses bundled libsrtp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Chromium Project
URL: http://code.google.com/p/chromium/iss...
Whiteboard:
Keywords:
Depends on: 438756
Blocks:
  Show dependency tree
 
Reported: 2010-12-13 11:41 UTC by Justin Lecher (RETIRED)
Modified: 2012-11-15 03:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2010-12-13 11:41:06 UTC 
Is there any reason why not to unbundle libsrtp? I found this because portage reports:

* QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
 * third_party/libsrtp/src/srtp/ekt.c:238:3: warning: implicit declaration of function ‘htons’
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
 * third_party/libsrtp/src/crypto/cipher/aes_icm.c:313:5: warning: implicit declaration of function ‘htonl’
 * third_party/libsrtp/src/crypto/cipher/aes_icm.c:347:3: warning: implicit declaration of function ‘htons’
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
 * third_party/libsrtp/src/srtp/srtp.c:604:4: warning: implicit declaration of function ‘htonl’
 * third_party/libsrtp/src/srtp/srtp.c:808:8: warning: implicit declaration of function ‘ntohs’
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
 * third_party/libsrtp/src/crypto/include/datatypes.h:418:4: warning: implicit declaration of function ‘ntohl’
Comment 1 Mike Gilbert gentoo-dev 2010-12-13 17:49:21 UTC 
Upstream bug tracking SRTP implementation: http://crbug.com/53986

Chromium tends to bundle libraries up front. Un-bundling is a an afterthought.
Comment 2 Mike Gilbert gentoo-dev 2011-05-12 02:20:59 UTC 
Upstream never implemented anything that actually uses this library.

http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/3166cb689a366b6f

A commit just landed to remove it.

http://src.chromium.org/viewvc/chrome?view=rev&revision=85092
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-10-17 23:00:05 UTC 
(In reply to comment #2)
> Upstream never implemented anything that actually uses this library.
> 
> http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/
> thread/3166cb689a366b6f
> 
> A commit just landed to remove it.
> 
> http://src.chromium.org/viewvc/chrome?view=rev&revision=85092

They restored it, e.g. http://codereview.chromium.org/9223031

I'm working on an upstream fix.
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-11-15 03:39:10 UTC 
Fixed in chromium-25.0.1323.1.