Bug 347355 – media-video/mkvtoolnix-4.4.0: should replace rake with bundled drake

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Milan Ševčík 2010-11-30 22:26:19 UTC]

Mkvtoolnix bundles drake which supports -jN option (more jobs).

Reproducible: Always

[Comment 1 Milan Ševčík 2010-11-30 22:36:04 UTC]

Created attachment 256001 [details]
ebuild using drake and MAKEOPTS

[Comment 2 Jeroen Roovers (RETIRED) 2010-12-07 02:42:45 UTC]

(In reply to comment #1)
> Created an attachment (id=256001) [details]
> ebuild using drake and MAKEOPTS

Please attach a patch next time so that the changes are obvious.

[Comment 3 shinydoofy 2011-01-21 20:10:36 UTC]

(In reply to comment #1)
> Created an attachment (id=256001) [details]
> ebuild using drake and MAKEOPTS
Works like a charm! The current ebuild doesn't play nice with x11-libs/wxGTK-2.9.1 installed and refuses to compile because the option for WX_CONFIG is missing, resulting in just "--with-wx-config="

[Comment 4 Milan Ševčík 2011-01-23 12:07:52 UTC]

Created attachment 260531 [details, diff]
Patch to use drake instead of rake and wxwidgets-2.8

Patched newer ebuild, fixed WX_CONFIG.

[Comment 5 Milan Ševčík 2011-01-23 12:09:16 UTC]

Created attachment 260532 [details]
Ebuild using drake and MAKEOPTS, fixed WX_CONFIG

[Comment 6 Milan Ševčík 2011-01-23 12:11:55 UTC]

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=256001) [details] [details]
> > ebuild using drake and MAKEOPTS
> Works like a charm! The current ebuild doesn't play nice with
> x11-libs/wxGTK-2.9.1 installed and refuses to compile because the option for
> WX_CONFIG is missing, resulting in just "--with-wx-config="
> 

This thing should be a problem even in mkvtoolnix from portage. I have fixed it in my ebuild, but there should be new bug opened I think.

[Comment 7 Tim Harder 2011-02-02 06:09:51 UTC]

I think instead of using the version of drake bundled with mkvtoolnix we should add drake [1] to the tree. I may try to do that before bumping mkvtoolnix to 4.5.0.

[1] http://rubyforge.org/projects/drake/

[Comment 8 Milan Ševčík 2011-02-02 15:40:23 UTC]

(In reply to comment #7)
> I think instead of using the version of drake bundled with mkvtoolnix we should
> add drake [1] to the tree. I may try to do that before bumping mkvtoolnix to
> 4.5.0.
> 
> [1] http://rubyforge.org/projects/drake/
> 

Well having drake in tree would be better. I just didn't want to write ebuild for something from scratch, especially when I know just one thing that would use it. As I can see now, the wxconf stuff haven't been fixed in tree yet, so hopefully this patch will go there also.

[Comment 9 Tim Harder 2011-02-02 20:07:42 UTC]

(In reply to comment #8)
> Well having drake in tree would be better. I just didn't want to write ebuild
> for something from scratch, especially when I know just one thing that would
> use it. As I can see now, the wxconf stuff haven't been fixed in tree yet, so
> hopefully this patch will go there also.

I fixed the wxconf stuff for 4.4.0 and 4.5.0 in the tree yesterday.

[Comment 10 Milan Ševčík 2011-02-02 21:24:19 UTC]

(In reply to comment #9)
> 
> I fixed the wxconf stuff for 4.4.0 and 4.5.0 in the tree yesterday.
> 

I see, my mistake. I was just looking at the beginning for WX_GTK_VER, but as I can see now, you did it different way...

[Comment 11 Kevin Korb 2012-06-15 19:26:21 UTC]

Note that dev-lang/ruby should be in the dependency list instead of dev-ruby/rake.  ./drake is a ruby script so the ebuild will fail if ruby is not installed.

[Comment 12 Tim Harder 2012-09-09 23:20:37 UTC]

Since I got tired of extra long mkvtoolnix builds on multi-core systems, 5.8.0 in CVS now uses the bundled drake support for building.