Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 345785 - sys-devel/flex autotools sanitisation for cross-compile
Summary: sys-devel/flex autotools sanitisation for cross-compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 18:24 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-11-16 20:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (flex-2.5.35_p10.ebuild,1.15 KB, text/plain)
2010-11-16 18:25 UTC, Diego Elio Pettenò (RETIRED)
Details
Autotools patch (flex-2.5.35-saneautotools.patch,2.86 KB, patch)
2010-11-16 18:25 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Comparison patch for the ebuild (flex-ebuild.patch,1.62 KB, patch)
2010-11-16 18:25 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-16 18:24:43 UTC
Okay, so flex fails to cross-compile right now without setting ac cache variables, plus has a number of hacks around it, mostly because its version of autotools are … pretty nasty.

The attached ebuild and patch (presented for review) applies the latest changes from the Debian package, and then sanitises the autotools build system to work as intended. While requiring an autotools rebuild, it takes care of a number of minor details in consideration, such as having an actual non-PIC library (as it is, it has been building _both_ PIC afaics).
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-16 18:25:00 UTC
Created attachment 254525 [details]
new ebuild
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-16 18:25:15 UTC
Created attachment 254527 [details, diff]
Autotools patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-16 18:25:55 UTC
Created attachment 254529 [details, diff]
Comparison patch for the ebuild
Comment 4 SpanKY gentoo-dev 2010-11-16 19:17:08 UTC
you probably want ${DEB_DIFF:+...}

i guess the isatty patch is also part of the Debian patchset ?

i'd prefer the epatch be kept as sep invocations as it's easier to add trailing comments that way

since you've updated the EAPI, might as well drop the die from econf

otherwise, this looks fine to me
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-16 19:22:15 UTC
Debian has a different solution for the isatty() prototype, they simply include unistd.h as long as _Win32 is not defined. I tested with doxygen (that was listed in the patch description) and it builds fine.

ACK for the multiple-epatch; I went this way to avoid a [[ -n ]] but I guess it looks clumsier this way than the other way.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-16 20:32:15 UTC
In tree.