Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 345725 - net-print/hplip should install udev rules in /lib*/udev/rules.d
Summary: net-print/hplip should install udev rules in /lib*/udev/rules.d
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 10:02 UTC by Ben Sagal
Modified: 2011-01-26 20:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
hplip-3.10.9-udev-rules-install-path.patch (hplip-3.10.9-udev-rules-install-path.patch,512 bytes, patch)
2010-11-16 21:54 UTC, Daniel Pielmeier
Details | Diff
update patch (hplip-3.10.9-udev-rules-install-path-r2.patch,522 bytes, patch)
2010-11-21 09:51 UTC, Ben Sagal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Sagal 2010-11-16 10:02:08 UTC
udev looks for rules in 2 locations /etc/udev/rules.d/ and /lib/udev/rules.d/.
system defined rules are supposed to be installed in /lib/udev/rules.d/ and not in etc, however hplip installs the rules into /etc/udev/rules.d/.


Reproducible: Always





checked with virstion 3.10.9
Comment 1 Daniel Pielmeier gentoo-dev 2010-11-16 21:35:31 UTC
Please open a bug upstream at https://launchpad.net/hplip about this issue and report the bug number here. Thank you.
Comment 2 Daniel Pielmeier gentoo-dev 2010-11-16 21:39:23 UTC
Seems like there is already a bug [1] with a comment from you.

[1] https://bugs.launchpad.net/hplip/+bug/500086
Comment 3 Daniel Pielmeier gentoo-dev 2010-11-16 21:54:25 UTC
Created attachment 254547 [details, diff]
hplip-3.10.9-udev-rules-install-path.patch

Attached patch to the current hplip ebuild should replace all occurrences of "/etc/udev/rules.d" with "/lib/udev/rules.d".
Comment 4 Ben Sagal 2010-11-21 09:51:32 UTC
Created attachment 254991 [details, diff]
update patch

the patch should really use $(get_libdir) instead of lib (as amd64 use lib64 not lib), fixed in update patch.

Apart from tat original patch works, thanks.
Comment 5 Daniel Pielmeier gentoo-dev 2010-11-21 12:27:23 UTC
(In reply to comment #4)
> the patch should really use $(get_libdir) instead of lib (as amd64 use lib64
> not lib), fixed in update patch.
> 
> Apart from tat original patch works, thanks.

You are correct. My sed was more a quick hack to test if it works. I don't think I will add it to the ebuild. This should be fixed in an upstream release.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-01-26 12:07:46 UTC
I'm partial at adding this to the ebuild already, given that right now on update we're asking users to ack the changes.
Comment 7 Daniel Pielmeier gentoo-dev 2011-01-26 20:11:35 UTC
(In reply to comment #6)
> I'm partial at adding this to the ebuild already, given that right now on
> update we're asking users to ack the changes.
> 

If you want to add it just uncomment the relevant lines in the ebuilds, as the sed is already there. If you prefer a patch feel free to create one. I became a bit cautious about adding unconfirmed patches (which are not that important), as upstream is tad slow with integrating them, and I don't want to recreate them with every new release. Especially when upstream is switching eol-markers from LF to CRLF back and forth.
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-01-26 20:25:43 UTC
Can I ask you please to enable the sed then? I'm unable to connect to CVS :(

And totally agree about avoiding patch files.
Comment 9 Daniel Pielmeier gentoo-dev 2011-01-26 20:51:48 UTC
(In reply to comment #8)
> Can I ask you please to enable the sed then? I'm unable to connect to CVS :(
> 
> And totally agree about avoiding patch files.
> 

+*hplip-3.11.1-r1 (26 Jan 2011)
+
+  26 Jan 2011; Daniel Pielmeier <billie@gentoo.org> -hplip-3.11.1.ebuild,
+  +hplip-3.11.1-r1.ebuild:
+  Revision bump to fix bug #345725. Thanks to Ben Sagal for reporting.

Fixed in cvs for hplip-3.11.1-r1. Closing this one for now. I will watch the upstream bug. Let's see how long it takes until they fix it.