Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 344353 - dev-db/sqlite-3.7.4 fixes for FreeMiNT
Summary: dev-db/sqlite-3.7.4 fixes for FreeMiNT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All FreeMiNT
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-06 09:20 UTC by Alan Hourihane
Modified: 2011-02-06 14:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Don't include sys/mman.h when OMIT_WAL used. (sqlite-3.7.0-mman.patch,308 bytes, patch)
2010-11-06 09:20 UTC, Alan Hourihane
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Hourihane 2010-11-06 09:20:16 UTC
Please add this to the src_configure() section for FreeMiNT

        if [[ "${CHOST}" == *-mint* ]] ; then
                append-cppflags -DSQLITE_OMIT_WAL
        fi

And add this in src_unpack...

        epatch "${FILESDIR}/${PN}-3.7.0-mman.patch"

With the attached file for files/

This patch was sent to Richard Hipp <drh@sqlite.org> a few months back but has yet to appear in a release, so I've resent it. It was also sent via the mailing lists.
Comment 1 Alan Hourihane 2010-11-06 09:20:41 UTC
Created attachment 253375 [details, diff]
Don't include sys/mman.h when OMIT_WAL used.
Comment 2 Fabian Groffen gentoo-dev 2010-11-09 18:03:22 UTC
@maintainer: ok?
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-11-15 03:07:51 UTC
This patch doesn't apply to non-amalgamation sources.
Which symbols from <sys/mman.h> are needed?
Comment 4 Alan Hourihane 2010-11-15 08:36:02 UTC
Basically when SQLITE_OMIT_WAL is defined we don't use mmap/munmap.
Comment 5 Alan Hourihane 2010-11-25 13:00:26 UTC
ping ?
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-12-12 18:09:54 UTC
This patch modifies generated file.
Please create the patch for original file and send the new patch to upstream:
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-dev
Comment 7 Alan Hourihane 2010-12-22 20:24:54 UTC
Modifies a generated file ??

If use sqlite-autoconf-3070400 from sqlite-3.7.4 I see sqlite3.c in it with sys/mman.h again.

Comment 8 Alan Hourihane 2010-12-22 20:35:21 UTC
I see a "Legacy Source Code Distribution Formats (Not Recommended)" zip file containing a file called src/os_unix.c which has the only <sys/mman.h> reference. 

Is this what you are referring to ?

Comment 9 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-12-22 20:39:14 UTC
The amalgamation tarball is generated from normal sources. The normal tarball is used with USE="tcl" or USE="test".
Comment 10 Alan Hourihane 2010-12-22 21:09:09 UTC
If I read it right, what you refer to as "normal" is actually "legacy" from the sqlite website.

Anyway, I've sent the patch to the sqlite-dev list.
Comment 11 Alan Hourihane 2011-01-19 11:40:40 UTC
Sent to sqlite-dev list twice and absolutely no reply to either post, gone into a black hole. :-(
Comment 12 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-06 13:40:08 UTC
http://www.sqlite.org/cgi/src/ci/b82e85ece9
Comment 13 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-06 14:04:17 UTC
Fixed in dev-db/sqlite-3.7.5.