Emerge of latest www-apache/passenger fails (log to follow) if dev-util/source-highlight is not installed. This, probably (I don't have time to check now, sorry) depends on the USE flag "doc" being enabled. emerging source-highlight lets passenger emerge and install fine. Reproducible: Always Steps to Reproduce:
Created attachment 253307 [details] failed build.log
There are two issues here: 1) passenger was missing a dependency on asciidoc which I've now added in CVS. 2) newer asciidoc versions now require dev-util/source-highlight when generating HTML output. I did not notice because I was still using 8.2.6. With asciidoc-8.5.3 this is now mandatory (from ./filters/source/source-highlight-filter.conf) # HTML outputs require GNU source-highlight # http://www.gnu.org/software/src-highlite/source-highlight.html Re-assigning to the asciidoc maintainers.
http://www.methods.co.nz/asciidoc/source-highlight-filter.html They state that both source-highlight or pygments would fit, but I have pygments installed on my own and asciidoc doesn't recognize it.
(In reply to comment #2) > 2) newer asciidoc versions now require dev-util/source-highlight when > generating HTML output. I did not notice because I was still using 8.2.6. With > asciidoc-8.5.3 this is now mandatory (from > ./filters/source/source-highlight-filter.conf) Both dev-util/source-highlight and dev-python/pygments seems to be a "soft dependency" of asciidoc: for instance, the complete docs of git build fine without it. We could add doc? ( dev-util/source-highlight ) to passenger instead. What do you think?
(In reply to comment #4) > Both dev-util/source-highlight and dev-python/pygments seems to be a "soft > dependency" of asciidoc: for instance, the complete docs of git build fine > without it. We could add > > doc? ( dev-util/source-highlight ) > > to passenger instead. What do you think? In that case I'd much rather add doc? ( app-text/asciidoc[highlight] ) to passenger. That leaves the responsibility for what that actually means with asciidoc where it belongs, and allows the asciidoc maintainer to handle things like required versions, alternative highlight implementations if any, etc. instead of scattering these throughout the tree.
(In reply to comment #5) > doc? ( app-text/asciidoc[highlight] ) That's a neat idea. I'll add that use flag and come back to you.
(In reply to comment #5) > In that case I'd much rather add > > doc? ( app-text/asciidoc[highlight] ) > > to passenger. Go ahead, use flag "highlight" just added to asciidoc.
Fixed for www-apache/passenger-3.0.2 in CVS. Thanks!
