Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 343791 - Make dev-lang/v8 compile on arm and keyword ~arm
Summary: Make dev-lang/v8 compile on arm and keyword ~arm
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2010-11-02 08:30 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified: 2010-11-19 17:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild supporting arm-compilation (v8-2.4.9.10.ebuild,1.85 KB, text/plain)
2010-11-08 21:47 UTC, Fabian Köster
Details
dev-lang:v8-2.5.4:20101114-210601.log (dev-lang:v8-2.5.4:20101114-210601.log,103.93 KB, text/plain)
2010-11-15 07:26 UTC, Markus Meier
Details
ARM arch detection patch (v8-arm.patch,489 bytes, patch)
2010-11-19 08:40 UTC, Fabian Köster
Details | Diff
ARM arch detection patch (v8-arm.patch,489 bytes, patch)
2010-11-19 08:43 UTC, Fabian Köster
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-11-02 08:30:34 UTC
www-client/chromium is keyworded ~arm, so before we can depend on dev-lang/v8, we should also keyword v8 ~arm.

If we're lucky, the only thing that needs work is the arch detection logic in the ebuild (need to add a case for arm). If the tests don't pass on ARM however, it's going to be more complicated. Anyway, a good first step would be to get it to compile on ARM.
Comment 1 Fabian Köster 2010-11-08 21:46:08 UTC
The arch-detection can easily be extended to support arm (see attached ebuild) and then dev-lang/v8-2.4.9.10 compiles and runs (in combination with www-client/chromium-8.0.552.28) just fine on this architecture.


Comment 2 Fabian Köster 2010-11-08 21:47:37 UTC
Created attachment 253707 [details]
Ebuild supporting arm-compilation
Comment 3 Markus Meier gentoo-dev 2010-11-15 07:26:04 UTC
Created attachment 254369 [details]
dev-lang:v8-2.5.4:20101114-210601.log

emerges and passes tests without problems.
@armin76: do you want to test it on armv7 as I just emerged it on my sheevaplug.
Comment 4 Fabian Köster 2010-11-19 08:39:43 UTC
I tested it on IGEPv2 which is armv7a, so please integrate the attached patch.
Comment 5 Fabian Köster 2010-11-19 08:40:20 UTC
Created attachment 254795 [details, diff]
ARM arch detection patch
Comment 6 Fabian Köster 2010-11-19 08:43:54 UTC
Created attachment 254797 [details, diff]
ARM arch detection patch
Comment 7 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-11-19 11:23:57 UTC
(In reply to comment #4)
> I tested it on IGEPv2 which is armv7a, so please integrate the attached patch.

Done (v8-2.5.6). Thanks for testing. Now looking forward to the ~arm keyword. :)
Comment 8 Markus Meier gentoo-dev 2010-11-19 13:47:13 UTC
~arm keyword added to -2.5.6, thanks for testing Fabian.
Comment 9 Robert Piasek (RETIRED) gentoo-dev 2010-11-19 17:35:07 UTC
tested on beagle-mx - all looks good.