Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 343473 - Please stabilize dev-ruby/json-1.4.6
Summary: Please stabilize dev-ruby/json-1.4.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2010-10-31 08:41 UTC by Hans de Graaff
Modified: 2011-01-29 17:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,14.21 KB, text/plain)
2010-10-31 19:09 UTC, Markos Chandras (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hans de Graaff gentoo-dev Security 2010-10-31 08:41:23 UTC
Please stabilize dev-ruby/json-1.4.6. This has been in the tree for several months and contains bug fixes compared to the current stable version.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2010-10-31 19:09:33 UTC
Created attachment 252705 [details]
build.log

Tests fail on amd64
Comment 2 Hans de Graaff gentoo-dev Security 2010-11-01 18:44:56 UTC
(In reply to comment #1)
> Created an attachment (id=252705) [details]
> build.log
> 
> Tests fail on amd64

This is bug 325745. It is not a regression from the currently stable version. I've had no luck reproducing it and thus fixing the problem. I don't think this needs to hold up stabilization although I would rather see this identified and fixed.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-11-02 06:31:57 UTC
Stable for HPPA.
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2010-11-05 10:38:21 UTC
/usr/bin/ruby18 -S testrb ./tests/test_json_rails.rb ./tests/test_json_unicode.rb ./tests/test_json_addition.rb ./tests/test_json.rb ./tests/test_json_
encoding.rb ./tests/test_json_generate.rb ./tests/test_json_fixtures.rb
Loaded suite [./tests/test_json_rails.rb, ./tests/test_json_unicode.rb, ./tests/test_json_addition.rb, ./tests/test_json.rb, ./tests/test_json_encoding
.rb, ./tests/test_json_generate.rb, ./tests/test_json_fixtures.rb]
Started
................................../lib/json/pure/parser.rb:198: warning: Float 23456789012E666 out of range
................F..
Finished in 2.97658 seconds.

  1) Failure:
test_symbol(TC_JSONRails) [./tests/test_json_rails.rb:142]:
<"\"foo\""> expected but was
<"{\"json_class\":\"Symbol\",\"s\":\"foo\"}">.

52 tests, 1932 assertions, 1 failures, 0 errors
rake aborted!
Command failed with status (1): [/usr/bin/ruby18 -S testrb ./tests/test_jso...]
/var/tmp/portage/dev-ruby/json-1.4.6/work/ruby18/json-1.4.6/Rakefile:44:in `myruby'
(See full trace by running task with --trace)
Comment 5 Hans de Graaff gentoo-dev Security 2010-11-06 10:09:03 UTC
(In reply to comment #4)

> /var/tmp/portage/dev-ruby/json-1.4.6/work/ruby18/json-1.4.6/Rakefile:44:in
> `myruby'

This tells me you are still using the old mechanism, so you are either testing json-1.4.6, or an old version of json-1.4.6-r1. Once it is clear that my change works it can be backported to 1.4.6.
Comment 6 David Abbott (RETIRED) gentoo-dev 2010-11-13 18:08:12 UTC
dev-ruby/json-1.4.6 from the summary fails tests

dev-ruby/json-1.4.6-r1 from comment #5 installs ok here on x86
52 tests, 1932 assertions, 0 failures, 0 errors

>>> Install json-1.4.6-r1 into /var/tmp/portage/dev-ruby/json-1.4.6-r1/image/ category dev-ruby
Comment 7 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-12-04 21:32:24 UTC
x86 stable, thanks David (no test failures here, or maybe I missed something)
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2011-01-05 19:41:45 UTC
amd64 done
Comment 9 Brent Baude (RETIRED) gentoo-dev 2011-01-07 20:52:02 UTC
ppc stable
Comment 10 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2011-01-22 20:53:17 UTC
1.4.6 fails tests same way as in c#4. 1.4.6-r1 works fine.
Diff r1 vs r0 shows only tests were affected, so why we're still stabilizing -r0?
Comment 11 Hans de Graaff gentoo-dev Security 2011-01-23 08:53:37 UTC
(In reply to comment #10)
> 1.4.6 fails tests same way as in c#4. 1.4.6-r1 works fine.
> Diff r1 vs r0 shows only tests were affected, so why we're still stabilizing
> -r0?

I have backported the new test mechanism to json 1.4.6 so test should now work there as well. Note that json-1.4.6-r1 cannot be stabilized due to ruby19 in USE_RUBY.

Comment 12 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2011-01-23 11:32:36 UTC
ppc64 stable
Comment 13 Raúl Porcel (RETIRED) gentoo-dev 2011-01-29 17:18:51 UTC
ia64/sparc stable, closing