Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 341171 - media-video/mplayer: strange video_cards_mda check in the ebuilds
Summary: media-video/mplayer: strange video_cards_mda check in the ebuilds
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-15 21:32 UTC by Faustus
Modified: 2011-12-15 14:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Faustus 2010-10-15 21:32:10 UTC 
Perhaps I am misunderstanding something, but shouldn't:

    if ! use kernel_linux && ! use video_cards_mga; then
         myconf+=" --disable-mga --disable-xmga"
    fi

actually be:

    if ! use kernel_linux || ! use video_cards_mga; then
    ...

Otherwise it doesn't make sense (no way to disable mga via USE flags).
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2010-11-01 13:27:36 UTC 
Fixed in live version. Thanks for spotting.
Comment 2 Alexis Ballier gentoo-dev 2011-12-15 14:56:34 UTC 
(In reply to comment #1)
> Fixed in live version. Thanks for spotting.

closing then