Hi all... Is it possible for the patch attached at the aforementioned URL to be included in Gentoo's TCL distribution (I'll attach it here in a moment)? It has been included in TCL 8.5.9. Without, the following error is seen: /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:77:21: error: sys/fpu.h: No such file or directory /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c: In function 'TclInitDoubleConversion': /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2170: error: storage size of 'mipsCR' isn't known /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2172: warning: implicit declaration of function 'get_fpc_csr' /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2174: warning: implicit declaration of function 'set_fpc_csr' /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2170: warning: unused variable 'mipsCR' distcc[623] ERROR: compile /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c on localhost failed
Created attachment 249411 [details, diff] Proposed tcl-8.5.8-mips-fpu.patch
CCing r0bertz, as he has a similar patch at http://gentoo-cn.org/gitweb/?p=loongson.git;a=blob;f=dev-lang/tcl/files/tcl-8.5-mips-fpu.h.patch and could perhaps comment as well. The MIPSpro compiler mention in Stuart's version seems to suggest only that compiler has a sys/fpu.h and should have that case then, so the attached version here is better?
Well, it's what upstream is already has included in their later release... hence my suggestion to include _that_ patch. I spotted the patch you refer to on the ActiveTCL mailing list... http://code.activestate.com/lists/tcl-core/9187/
Sorry, didn't read the opening sentence carefully enough. Yes, we should use what upstream went with. I'll sync loongson overlay with it meanwhile (it's behind a revbump already anyway), once in-tree tcl has it, we can get rid of it from overlay :)
Is this fixed with 8.5.9? If so, can we just drop old keywords?
(In reply to comment #5) > Is this fixed with 8.5.9? If so, can we just drop old keywords? I have just checked. It is fixed in 8.5.9. So we can just keyword 8.5.9.
Dropped keyword for <tcl-8.5.9.