339571 – dev-lang/tcl-8.5.8-r2 broken on mips: sys/fpu.h not found

Bug 339571 - dev-lang/tcl-8.5.8-r2 broken on mips: sys/fpu.h not found

Summary: dev-lang/tcl-8.5.8-r2 broken on mips: sys/fpu.h not found

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	MIPS Linux

Importance:	High normal (vote)
Assignee:	TCL/TK Project

URL:	http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-10-03 09:50 UTC by Stuart Longland (RETIRED)
Modified:	2010-12-23 18:37 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Proposed tcl-8.5.8-mips-fpu.patch (2819200.patch,840 bytes, patch) 2010-10-03 09:51 UTC, Stuart Longland (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stuart Longland (RETIRED) gentoo-dev

2010-10-03 09:50:19 UTC

Hi all...

Is it possible for the patch attached at the aforementioned URL to be included in Gentoo's TCL distribution (I'll attach it here in a moment)?  It has been included in TCL 8.5.9.

Without, the following error is seen:

/tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:77:21: error: sys/fpu.h: No such file or directory
/tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c: In function 'TclInitDoubleConversion':
/tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2170: error: storage size of 'mipsCR' isn't known
/tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2172: warning: implicit declaration of function 'get_fpc_csr'
/tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2174: warning: implicit declaration of function 'set_fpc_csr'
/tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c:2170: warning: unused variable 'mipsCR'
distcc[623] ERROR: compile /tmp/portage/dev-lang/tcl-8.5.8-r2/work/tcl8.5.8/unix/../generic/tclStrToD.c on localhost failed

Comment 1 Stuart Longland (RETIRED) gentoo-dev

2010-10-03 09:51:06 UTC

Created attachment 249411 [details, diff]
Proposed tcl-8.5.8-mips-fpu.patch

Comment 2 Mart Raudsepp gentoo-dev

2010-10-03 10:02:13 UTC

CCing r0bertz, as he has a similar patch at http://gentoo-cn.org/gitweb/?p=loongson.git;a=blob;f=dev-lang/tcl/files/tcl-8.5-mips-fpu.h.patch and could perhaps comment as well. The MIPSpro compiler mention in Stuart's version seems to suggest only that compiler has a sys/fpu.h and should have that case then, so the attached version here is better?

Comment 3 Stuart Longland (RETIRED) gentoo-dev

2010-10-03 10:34:15 UTC

Well, it's what upstream is already has included in their later release... hence my suggestion to include _that_ patch.  I spotted the patch you refer to on the ActiveTCL mailing list...

http://code.activestate.com/lists/tcl-core/9187/

Comment 4 Mart Raudsepp gentoo-dev

2010-10-03 11:27:24 UTC

Sorry, didn't read the opening sentence carefully enough. Yes, we should use what upstream went with. I'll sync loongson overlay with it meanwhile (it's behind a revbump already anyway), once in-tree tcl has it, we can get rid of it from overlay :)

Comment 5 Matt Turner gentoo-dev

2010-12-14 03:29:20 UTC

Is this fixed with 8.5.9? If so, can we just drop old keywords?

Comment 6 Zhang Le (RETIRED) gentoo-dev

2010-12-19 12:17:01 UTC

(In reply to comment #5)
> Is this fixed with 8.5.9? If so, can we just drop old keywords?

I have just checked. It is fixed in 8.5.9. So we can just keyword 8.5.9.

Comment 7 Matt Turner gentoo-dev

2010-12-23 18:37:32 UTC

Dropped keyword for <tcl-8.5.9.