338671 – sys-fs/squashfs-tools-4.1 does not honour USE=xattr

Bug 338671 - sys-fs/squashfs-tools-4.1 does not honour USE=xattr

Summary: sys-fs/squashfs-tools-4.1 does not honour USE=xattr

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo LiveCD Package Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-25 13:50 UTC by Martin Väth
Modified:	2010-10-07 02:15 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch for the ebuild to fix the two mentioned issues (squashfs-tools-4.1.patch,692 bytes, patch) 2010-09-25 13:52 UTC, Martin Väth	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Väth 2010-09-25 13:50:34 UTC

The ebuild of sys-fs/squashfs-tools-4.1 has USE=xattr but ignores both settings:
With USE=-xattr, the line XATTR_SUPPORT=1 should be removed from the Makefile.
Conversely, with USE=xattr, the package should DEPEND on sys-apps/attr,
since otherwise compilation will fail (I have not tried, but strongly assume
that this is also a runtime dependency).

Comment 1 Martin Väth 2010-09-25 13:52:39 UTC

Created attachment 248599 [details, diff]
Patch for the ebuild to fix the two mentioned issues

Comment 2 SpanKY gentoo-dev

2010-10-07 02:15:45 UTC

thanks, ive added that and fixed up the code in general

http://sources.gentoo.org/sys-fs/squashfs-tools/squashfs-tools-4.1.ebuild?r1=1.1&r2=1.2