Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336643 - www-client/midori-0.2.7[vala] should depend on dev-lang/vala
Summary: www-client/midori-0.2.7[vala] should depend on dev-lang/vala
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 19:41 UTC by René 'Necoro' Neumann
Modified: 2010-09-29 02:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2010-09-09 19:41:49 UTC
midori-0.2.7 has an option to enable vala support. But this flag does not pull in vala as a dependency.

Looking at the midori code:

if option_enabled ('vala'):
    if find_program_impl (conf.env, 'valac'):
        conf.check_tool ('vala')
    else:
        conf.check_message ('program', 'valac', False, False)
        Utils.pprint ('RED', 'Vala is required for some extensions.')
        Utils.pprint ('RED', 'Pass --disable-vala to not build with Vala.')
        sys.exit (1)


it needs valac when the 'vala' option is required. Thus dev-lang/vala should be in the deps. I'm unsure however, whether it should be only in DEPEND or also in RDEPEND.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-09-20 14:39:42 UTC
Yup, simple mistake. It should be in RDEPEND (run-time, "some" extensions) and DEPEND (build time, as you pointed out).

Now, vala is SLOTted so it needs some extra investigation.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-09-29 02:40:28 UTC
+*midori-0.2.8 (29 Sep 2010)
+
+  29 Sep 2010; Samuli Suominen <ssuominen@gentoo.org> +midori-0.2.8.ebuild,
+  midori-9999.ebuild:
+  Version bump with missing dev-lang/vala depend wrt #336643 by Agostino
+  Sarubbo and pax-mark -m for hardened wrt #338561 by René Neumann.