The file dbus-1.2.24-thread-safety.patch exists, but there is no corresponding epatch instruction in the ebuild. Hence the patch is not applied (which for example causes freezes in Dolphin 1.5 from KDE 4.5.1 when previewing files/showing tooltips, see the comments on http://dot.kde.org/2010/08/31/kde-releases-451). Applying the patch by adding epatch "${FILESDIR}"/${P}-thread-safety.patch to src_prepare() in the ebuild and re-emerging helped fixes those freezes for me. Reproducible: Always
Created attachment 246588 [details] fixed ebuild including epatch instruction
(In reply to comment #1) > Created an attachment (id=246588) [details] > fixed ebuild including epatch instruction > Please add " || die " in src_prepare() later on sed in src_install() later on newinitd,keepdir and dodoc. All for qa questions :)
please provide a unified diff against in tree ebuild. thanks.
Created attachment 246611 [details, diff] patch for ebuild Patch adding epatch instruction and appending "|| die" after sed, newinitd, keepdir and dodoc as suggested by Agostino Sarubbo in #2.
+*dbus-1.3.0-r3 (09 Sep 2010) +*dbus-1.2.24-r2 (09 Sep 2010) + + 09 Sep 2010; Gilles Dartiguelongue <eva@gentoo.org> -dbus-1.2.3-r1.ebuild, + -files/dbus-1.2.3-bsd.patch, + -files/dbus-1.2.3-panic-from-dbus_signature_validate.patch, + +dbus-1.2.24-r2.ebuild, +dbus-1.3.0-r3.ebuild: + Apply thread safety patch from master, bug #336588. Sync dbus-1.2 with 1.3 + ebuild enhancements. Clean up old revision. Applied, thanks for reporting.
05 Aug 2010; Maciej Mrozowski <reavertm@gentoo.org> +files/dbus-1.2.24-thread-safety.patch: Commited backport from master to 1.2.24 (bug https://bugs.freedesktop.org/show_bug.cgi?id=17754) - patch to fix thread safety in protected_change_timeout for further review. So, patch was intentionally left out. Mentioned dolphin issues are most likely originated elsewhere - in 4.5.0 there was strigi API misuse introduced (that assumed strigi thread safety, which is not the case). Yet I have it applied here for quite some time, no issues and there are test cases that prove patch fixes actual dbus thread safety issues, so it's safe to commit. Thanks Gilles.