335977 – net-ftp/vsftpd does not respect -Wl,--as-needed

Bug 335977 - net-ftp/vsftpd does not respect -Wl,--as-needed

Summary: net-ftp/vsftpd does not respect -Wl,--as-needed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Server (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Markos Chandras (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-04 17:13 UTC by Joakim Tjernlund
Modified:	2010-09-27 17:18 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joakim Tjernlund 2010-09-04 17:13:49 UTC

LDFLAGS needs to be before LIBS for --as-needed to work. This patch fixes it:
--- Makefile.org	2010-09-04 17:55:24.000000000 +0200
+++ Makefile	2010-09-04 18:22:09.000000000 +0200
@@ -21,7 +21,7 @@
 	$(CC) -c $*.c $(CFLAGS) $(IFLAGS)
 
 vsftpd: $(OBJS) 
-	$(CC) -o vsftpd $(OBJS) $(LINK) $(LIBS) $(LDFLAGS)
+	$(CC) -o vsftpd $(LDFLAGS) $(OBJS) $(LINK) $(LIBS)
 
 install:
 	if [ -x /usr/local/sbin ]; then \


Reproducible: Always

Comment 1 Joakim Tjernlund 2010-09-10 07:44:08 UTC

Ping?

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2010-09-10 09:23:41 UTC

Please do not ping us. We are 'alive' and haven't forgotten about this, we just need to make some time to apply this fix ( and the other one about vsftpd ) and test the package. 

Thank you :)

Comment 3 Markos Chandras (RETIRED) gentoo-dev

2010-09-27 17:18:35 UTC

Fixed. Thanks a lot for your contribution. Reopen if needed