Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 335563 - IPv6 payload for net-misc/openvpn-2.1.4
Summary: IPv6 payload for net-misc/openvpn-2.1.4
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Dirkjan Ochtman (RETIRED)
URL:
Whiteboard:
Keywords:
: 357923 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-01 15:56 UTC by Fabio Coatti
Modified: 2012-02-17 09:43 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for cumulative ipv6 patch (openvpn-2.1.2.ebuild,5.31 KB, text/plain)
2010-09-07 09:29 UTC, Fabio Coatti
Details
cumulative ipv6 patch (openvpn-2.1.2-ipv6.patch.gz,55.54 KB, patch)
2010-09-07 09:30 UTC, Fabio Coatti
Details | Diff
Ebuild for openvpn-2.1.3 with combined ipv6 patch (openvpn-2.1.3-r1.ebuild,5.35 KB, text/plain)
2010-09-28 17:24 UTC, Jens Ott
Details
The patch for openvpn 2.1.3 (openvpn-2.1.3-ipv6.patch.gz,55.48 KB, patch)
2010-09-28 17:24 UTC, Jens Ott
Details | Diff
Ebuild for openvpn-2.1.4 including the combined IPv6-Patch (the one from 2.1.3 works without modifications) (openvpn-2.1.4-r1.ebuild,5.65 KB, text/plain)
2010-12-15 11:48 UTC, Jens Ott
Details
Documentatio and cleanup patch to the ebuild (openvpn-2.1.4.patch,824 bytes, patch)
2011-03-09 10:27 UTC, Paolo Pedroni
Details | Diff
small patch to fix conflict between transport/payload patch (my.patch,3.70 KB, patch)
2011-05-01 15:37 UTC, yegle
Details | Diff
Modified OpenVPN ebuild (openvpn-2.2.0-r2.ebuild,5.42 KB, text/plain)
2011-05-01 15:38 UTC, yegle
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Coatti 2010-09-01 15:56:17 UTC
Can be possible to add Gert Döring patch for ipv6 payloads http://www.greenie.net/ipv6/openvpn.html on ipv4 tunnels to openvpn ebuild?
I've slightly modified openvpn-2.1.2 ebuild to include a patch that merges the ipv6 patch already present in the ebuild (that is for ipv6 tunnel itself) and Gert patch.
It's tested only because I use it on a regular basis, but if this can be useful I can attach the files.
let me know.


Reproducible: Always
Comment 1 Gert Doering 2010-09-07 09:12:43 UTC
Hi,

this feature request has been brought to my attention.  

I just want to mention that I'm happy to help with any questions that might arise regarding patch conflicts etc. (and I'm a gentoo user, so I can test the build).

I'm not the gentoo maintainer, though, just to avoid confusion here :-)

gert
Comment 2 Fabio Coatti 2010-09-07 09:24:58 UTC
Hi Gert, 
nice to see you on this bug:)

Basically I'm using your patch applied to latest gentoo ebuild for openvpn that already has jjo ipv6 patch.

I'll post here my modification that are just a quick hack to allow me to use my laptop with ipv6, as I said I've not tested deeply the side effects of the merge, but maybe this can be useful so I post here the ebuild and the merged patch.
Comment 3 Fabio Coatti 2010-09-07 09:29:17 UTC
Created attachment 246336 [details]
Ebuild for cumulative ipv6 patch
Comment 4 Fabio Coatti 2010-09-07 09:30:24 UTC
Created attachment 246337 [details, diff]
cumulative ipv6 patch
Comment 5 Gert Doering 2010-09-07 10:15:29 UTC
Do I understand this right, this patch is "ipv6 payload + ipv6 transport" merged into one big "IPv6 patch" (it certainly looks like it :-) ).

From a cursory glance, it looks good to me (the only real conflict is in mroute.c, and you sorted that out).
Comment 6 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-09-07 10:18:45 UTC
Thanks for the review. I'll probably extend the meaning of the ipv6 use flag to incorporate the merged transport + payload patch in 2.1.2-r1, soon.
Comment 7 Fabio Coatti 2010-09-07 10:20:50 UTC
(In reply to comment #5)
> Do I understand this right, this patch is "ipv6 payload + ipv6 transport"
> merged into one big "IPv6 patch" (it certainly looks like it :-) ).
> 


Yes, well put, it is exactly as you said :)

> From a cursory glance, it looks good to me (the only real conflict is in
> mroute.c, and you sorted that out).
> 

Thanks for looking at it!

Comment 8 Martin Gollowitzer 2010-09-12 10:46:12 UTC
Hi,

I just stumbled over this bug and realized that nothing has happened for quite some time. How are chances that an OpenVPN version with Gert's patch applied will be made available? Until now I use 2.1.0-r1 which I patched manually (That was not easy for me since I'm not a programmer but had to fix two files manually!).

Thanks,
Martin
Comment 9 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-09-12 12:01:05 UTC
Errr, 5 days doesn't qualify as quite some time. I'll get to it sometime soon, but I won't make promises.
Comment 10 Martin Gollowitzer 2010-09-12 12:16:35 UTC
Whoops, I read the date the wrong way :/
I guess I've had too much contact with people writing YYYY-DD-MM recently...

Sorry,
Martin
Comment 11 Jens Ott 2010-09-28 17:22:25 UTC
Hi,

in the meantime openvpn 2.1.3 has been jumped into portage-tree, so I adapted the patch to that version. Only some minor line changes happened. Additionally the patches of install-win32/settings.in (change of release-date) didn't match, but I'm pretty sure that this change can silently ignored.

If not, the PRODUCT_TAP_RELDATE is now defined in win/settings.in, feel free to change it there if this is really needed ;-)

Anyways, find attached the ebuild (2.1.3-r1) and the combined patch for 2.1.3.

BR
Jens
Comment 12 Jens Ott 2010-09-28 17:24:03 UTC
Created attachment 248921 [details]
Ebuild for openvpn-2.1.3 with combined ipv6 patch
Comment 13 Jens Ott 2010-09-28 17:24:32 UTC
Created attachment 248923 [details, diff]
The patch for openvpn 2.1.3
Comment 14 Fabio Coatti 2010-09-29 06:48:30 UTC
(In reply to comment #11)
> Hi,
> 
> in the meantime openvpn 2.1.3 has been jumped into portage-tree, so I adapted
> the patch to that version. 

Works just fine, thanks.

Comment 15 Jens Ott 2010-11-03 19:51:44 UTC
(In reply to comment #9)
> Errr, 5 days doesn't qualify as quite some time. I'll get to it sometime soon,
> but I won't make promises.
> 

How about 2 month? ... does this qualify for "quite some time" ? *scnr*

Is there any perspective to get this patch into portage ... well ... maybe until end of this year?

BR
Jens
Comment 16 Jens Ott 2010-12-15 11:48:01 UTC
Created attachment 257218 [details]
Ebuild for openvpn-2.1.4 including the combined IPv6-Patch (the one from 2.1.3 works without modifications)

No that openvpn 2.1.4 entered into portage, again without the IPv6-Payload-Patch, I changed that ebuild to use the combined patch (as already attached for 2.1.3) instead of the originally included patch.
The ported combined-patch we submitted for 2.1.3 works for 2.1.4 without modification, so I did refer to that one instead of renaming it. Feel free to rename it when (if ever?) pushing that into official portage-tree.

BR
Jens
Jens
Comment 17 Jens Ott 2010-12-15 11:52:01 UTC
@Fabio: Maybe you want to change summary of this report to reflect that we already arrived on 2.1.4 with proposing this patch and no longer on 2.1.2 ... I don't have sufficient permissions for it as you filed this report initially ;-)

BR
Jens
Comment 18 Fabio Coatti 2010-12-15 12:18:51 UTC
Done :)
Comment 19 Paolo Pedroni 2011-03-08 15:54:02 UTC
*** Bug 357923 has been marked as a duplicate of this bug. ***
Comment 20 Paolo Pedroni 2011-03-08 16:06:51 UTC
A few more months have passed, 2.1.4 is now stable, and this patch is still nowhere to be seen. Please, Dirkjan, the work is all done for you, commit this to the tree (in an ~arch -r1 if you prefer to be safe).
Comment 21 Paolo Pedroni 2011-03-09 10:27:53 UTC
Created attachment 265273 [details, diff]
Documentatio and cleanup patch to the ebuild

This patch adds some IPv6 documentation to /usr/share/doc/openvpn-2.1.4 and fixes the einfo at the end (the IPv6 transport patch is the one from JuanJo Ciarlante and Gert Doering's one is the IPv6 payload patch).
Comment 22 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-04-30 21:06:32 UTC
Sorry this has taken so long to get to. I've now put 2.2.0 in the tree and included support for the latest IPv6-payload patch from Gert. Please review and file new bugs if anything's failing.
Comment 23 yegle 2011-05-01 14:27:50 UTC
(In reply to comment #22)
> Sorry this has taken so long to get to. I've now put 2.2.0 in the tree and
> included support for the latest IPv6-payload patch from Gert. Please review and
> file new bugs if anything's failing.

Hi Dirkjan Ochtman,

If I understand correctly, the patch from Gert only contains *IPv6 Payload* patch, not the combination of jjo's **IPv6 Transport** patch.

Quote from Gert's website:
OpenVPN v2.1 has no support for transporting VPN packets over IPv6 transport (``IPv4, IPv6 or Ethernet inside, IPv6 outside'') either, but there are other people already working on this, so I did not touch this field.

By check Gert's patch I can confirm that the options added by jjo ( --proto udp6 and so on ) was not included in Gert's patch.

IPv6 Payload patch allows "IPv4-inside-IPv6" connection, which gives IPv6-only servers the ability to access IPv4 network.
IPv6 Transport patch allows "IPv6-inside-IPv4", which gives IPv4-only servers the ability to access to IPv6 network.

Please check if this is really a regression.
Comment 24 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-05-01 14:41:02 UTC
Hmm, you might be right. On the other hand, I couldn't extract a useful working patch (e.g. something that applied using epatch) from jjo's github repo. Maybe someone else could help out with that?
Comment 25 Jens Ott 2011-05-01 14:49:12 UTC
Did you red our thread completely? The patches supplied by Fabio and me are merges of Gerts and JJO's patch! They support bot Transport and Payload of V6!

BR
Jens
Comment 26 yegle 2011-05-01 14:52:31 UTC
(In reply to comment #25)
> Did you red our thread completely? The patches supplied by Fabio and me are
> merges of Gerts and JJO's patch! They support bot Transport and Payload of V6!
> 
> BR
> Jens

Hi Jens Ott,

There maybe some mistake. The patch used in ebuild file is:
http://www.greenie.net/ipv6/openvpn-${IPV6_PAYLOAD_VERSION}.patch.gz

Which obviously doesn't contain jjo's patch.
Comment 27 Jens Ott 2011-05-01 15:09:53 UTC
OK, that makes no big sense ... maybe you should use the patch provided as attachment of this bugreport then. That's way we did the merge!
Comment 28 yegle 2011-05-01 15:14:14 UTC
(In reply to comment #27)
> OK, that makes no big sense ... maybe you should use the patch provided as
> attachment of this bugreport then. That's way we did the merge!

Hi Jens Ott,

I found the latest openvpn ebuild (2.2.0-r1) in portage tree contains only the IPv6 payload patch, so I'm trying to report a bug report and then I found this issue. Does this mean I need to open another issue?
Comment 29 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-05-01 15:24:00 UTC
No, let's address it here.

Guys, can you come up with a new combined patch, for 2.2.0, that has both the patches and provides proper credits to respective authors of the patches?
Comment 30 yegle 2011-05-01 15:37:05 UTC
Created attachment 271763 [details, diff]
small patch to fix conflict between transport/payload patch
Comment 31 yegle 2011-05-01 15:38:27 UTC
Created attachment 271765 [details]
Modified OpenVPN ebuild
Comment 32 yegle 2011-05-01 15:41:12 UTC
Use http://bugs.gentoo.org/attachment.cgi?id=271763 to patch the "IPv6 transport patch" first, then apply "IPv6 payload patch" and "IPv6 transport patch" in order.

The modified ebuild: http://bugs.gentoo.org/attachment.cgi?id=271765

This is ugly but it works.
Comment 33 Dirkjan Ochtman (RETIRED) gentoo-dev 2012-02-17 09:43:20 UTC
We're not going to do anymore than we already have; we'll wait for 2.3, which has this support in upstream.