Upstream changed configure and added some new options, also this patch fixes automagick deps: http://git.mplayerhq.hu/?p=mplayer;a=history;f=configure;hb=HEAD http://git.mplayerhq.hu/?p=mplayer;a=commitdiff;h=72a524ddba0b44d6633b06d88260713bf339669b;hp=434a297647e968a32fb4e1ec3efd4cd9e53779c9 http://git.mplayerhq.hu/?p=mplayer;a=commitdiff;h=04b854aa03dc8fc1a68fff411217896c22b0b949 http://git.mplayerhq.hu/?p=mplayer;a=commitdiff;h=394ee219caace124970a525deeda81a957745570 http://git.mplayerhq.hu/?p=mplayer;a=commitdiff;h=e254591d2379134f15b9e810c4d5c00dd8ee0e11 http://git.mplayerhq.hu/?p=mplayer;a=commitdiff;h=c2def3d5cd615deac508d1f08b09780c47881e6b Reproducible: Always
Created attachment 244913 [details, diff] diff
Make mpeg2 use flag libmpeg2, since it will still support MPEG2 playback natively. I wouldn't wrap mpg321 use flag inside dep of mp3.
I wanted to use this patch to offer an updated mplayer ebuild for bug 331583. However, I'm a bit confused about the following... (In reply to comment #2) > Make mpeg2 use flag libmpeg2, since it will still support MPEG2 playback > natively. As in "rename it"? Could you elaborate what that would change in the big picture?
(In reply to comment #3) > I wanted to use this patch to offer an updated mplayer ebuild for bug 331583. > However, I'm a bit confused about the following... > (In reply to comment #2) > > Make mpeg2 use flag libmpeg2, since it will still support MPEG2 playback > > natively. > As in "rename it"? Could you elaborate what that would change in the big > picture? > Right, rename it. If you have a use flag named "mpeg2" than it would probably make people assume that, to playback MPEG-2 videos, they need this use flag enabled. That's not the case. If it's called "libmpeg2" then it looks more like a library, than a core dependency.
Thank you for your quick response. I've fiddled with the handling of use flags a bit to allow both mp3 and mpg123 at the same time and either using the external or internal libmpeg2. If there is nothing else wrong with this set of changes, I propose taking the current ebuild from bug 331583 for -9999 as well to support libbluray for svn enthusiasts.
Created attachment 246279 [details] fixed Sorry for delay. shinydoofy, we do not need +libmpeg2, we already have ffmpeg decoders (mplayer -vc help|grep 'MPEG.*2').
I didnt notice this bug before i did my changes today to ffmpeg. Woudl you mind creating new patchset? What was not done in my changeset: libmpeg mpg123 gsm check if it works properly: external-ffmpeg
Created attachment 250653 [details, diff] updated for mplayer-9999.ebuild,v 1.82
Created attachment 250659 [details] libdvdnav-4.1.3 and libdvdread-4.1.3 are stable now external-ffmpeg works fine. Why you added '--enable-libdvdcss-internal' to macosx prefix? Are there any problems with using external dvd libs?
Added to main tree. Feel free to ping me on irc with additional updates or open new bugs :)
