Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 333945 - mail-client/thunderbird: wrong lightning localization
Summary: mail-client/thunderbird: wrong lightning localization
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 354315 389677 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-22 12:13 UTC by cache
Modified: 2016-08-11 11:14 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bashrc (bashrc,1.46 KB, text/plain)
2013-11-06 06:41 UTC, Small_Penguin
Details
patch to thunderbird-24.1.0-r1 ebuild (patch2,2.19 KB, patch)
2013-11-06 21:30 UTC, Ian Stakenvicius (RETIRED)
Details | Diff
patch to thunderbird-24.1.0-r1.ebuild (patch,2.12 KB, patch)
2013-11-07 16:34 UTC, Ian Stakenvicius (RETIRED)
Details | Diff
patch to thunderbird-24.0.1-r1.ebuild (patch,4.05 KB, patch)
2013-11-08 19:12 UTC, Ian Stakenvicius (RETIRED)
Details | Diff
thunderbird-24.1.0-r2.diff (thunderbird-24.1.0-r2.diff,4.03 KB, patch)
2013-11-08 22:23 UTC, Daniel Pielmeier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cache 2010-08-22 12:13:51 UTC
Integrated lightning (installed with "lightning" USE flag with thunderbird) has no correct localization. While in my case thunderbird has correct ru-RU locale, lightning has en-US. Xpi from ftp://ftp.mozilla.org/pub/calendar/lightning/releases/1.0b2/contrib/linux-x86_64/lightning.xpi for amd64 and https://addons.mozilla.org/ru/thunderbird/downloads/latest/2313 for i686 has correct localization.

This bug present at least in i686 and amd64 platforms.

Reproducible: Always

Steps to Reproduce:
1. Install mail-client/thunderbird-3.1.2 with USE="lightning" and LINGUAS="ru".
2. Run with locale ru_RU.utf8.
3. Thunderbird has correct ru-RU locale while lightning has not.




--------- make.conf -----------
CFLAGS="-march=k8 -O2 -pipe"
CXXFLAGS="-march=k8 -O2 -pipe"
LDFLAGS="-Wl,-O1,--hash-style=gnu,--sort-common,--as-needed"

CHOST="x86_64-pc-linux-gnu"
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="AdobeFlash-10"

USE="theora spell wifi lzma -qt -qt4 -kde -tcl -tk gtk xfce thunar X -arts -oss -esd -jack -nas -pulseaudio unicode -ipv6 hal udev dbus truetype jpeg custom-optimization -abiword svg xcb png gnutls tiff samba startup-notification libnotify -acl gallium gallium3d laptop 7zip alsa pango cairo bluetooth threads mmx mmxext sse sse2 3dnow 3dnowext libsexy"
VIDEO_CARDS="radeonhd radeon"
LINGUAS="ru"
MAKEOPTS="-j10"
GENTOO_MIRRORS="http://gentoo.inode.at/ "
SANE_BACKENDS="plustek gt68xx"

PORTAGE_NICENESS="20"
PORTDIR_OVERLAY="/usr/local/portage"

source /var/lib/layman/make.conf

----------- uname -a ---------------
Linux cache 2.6.34-gentoo-r2-cache #1 SMP Mon Jul 26 15:46:17 MSD 2010 x86_64 AMD Turion(tm) 64 X2 Mobile Technology TL-64 AuthenticAMD GNU/Linux
Comment 1 Bruno 'brubru' Tarquini 2010-09-11 10:28:55 UTC
Same problem with french locale and thunderbird-3.1.3:

I found the the situation is like this:

* TB is built from «http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/3.1.3/source/thunderbird-3.1.3.source.tar.bz2» which doesn't ship any locales, but it have the lightning source (in /comm-1.9.2/calendar/).

* The locales comes from «http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/3.1.3/linux-i686/xpi/fr.xpi -> thunderbird-3.1.3-fr.xpi» which doesn't ship locales of lightning as the extension isn't officially in TB (even if it's in the source code).

* The locales are in the tarball released by Mozilla for lightning:
   - lightning-1.0b2-tb-linux.xpi:
        /chrome/calendar-fr.jar
        /chrome/lightning-fr.jar

A simple workaround is to extract theses two files and put them into:
/usr/lib/thunderbird/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/

Then, add to .../thunderbird/extensions/{e2fda1a4-...}/chrome.manifest theses two lines:
--
locale calendar fr jar:chrome/calendar-fr.jar!/locale/fr/calendar/
locale lightning fr jar:chrome/lightning-fr.jar!/locale/fr/lightning/
--

Obviously, it's needed to update this to the locale.
Comment 2 Jory A. Pratt gentoo-dev 2011-02-11 14:25:15 UTC
*** Bug 354315 has been marked as a duplicate of this bug. ***
Comment 3 mori rámar 2011-05-17 15:34:57 UTC
The lightning in the thunderbird-3.1.10 is 1.0beta3pre. The address might need update.
Comment 4 mori rámar 2011-05-18 16:31:28 UTC
Sorry, I got it wrong.

I am trying to find locales for lightning and other 2 extensions (timezones and gdata-provider). But I cannot find official download link of calendar-timezones.xpi. Anyone can help? Thank you.
Comment 5 Daniel Pielmeier gentoo-dev 2011-10-25 17:38:08 UTC
Jory in bug #333945 from 2011-02-11 you said you will take a look at it next week. Maybe you forgot about it?
Comment 6 Daniel Pielmeier gentoo-dev 2011-10-25 17:39:03 UTC
(In reply to comment #5)
> Jory in bug #333945 from 2011-02-11 you said you will take a look at it next
> week. Maybe you forgot about it?

Sorry I meant bug #354315.
Comment 7 Jory A. Pratt gentoo-dev 2011-10-27 00:37:09 UTC
(In reply to comment #5)
> Jory in bug #333945 from 2011-02-11 you said you will take a look at it next
> week. Maybe you forgot about it?

I have not forgotten about it, I have had much real life work to deal with as of late, I will get it finished just as soon as possible.
Comment 8 Nirbheek Chauhan (RETIRED) gentoo-dev 2012-01-28 06:42:46 UTC
This still seems to be an issue.
Comment 9 Nirbheek Chauhan (RETIRED) gentoo-dev 2012-01-28 06:42:51 UTC
*** Bug 389677 has been marked as a duplicate of this bug. ***
Comment 10 Marian Kyral 2012-04-19 10:43:38 UTC
I've investigated this a little as I want ligtning in czech in TB 11.0.1. The only think I've found is https://developer.mozilla.org/en/Calendar/Localization#Building_Lightning_in_your_Language

It looks like correct way, but I don't know, where to get the locale source for the current TB version :-(
Comment 11 Small_Penguin 2012-04-30 07:21:05 UTC
I confirm this issue as a user of the german locale.

And another issue regarding locales: After an update of thunderbird, all folder names are in English until the next restart.
Comment 12 Per Pomsel 2013-04-08 07:29:04 UTC
Just someone who is going to fix that?
It's annoying when all send their invitations in German, but not the gentoo users.
Comment 13 Andreas Sturmlechner gentoo-dev 2013-06-01 22:36:19 UTC
Still an issue with 17.0.6, worked around here by installing the 1.9.1 release manually.
Comment 14 cyberbat 2013-06-24 11:38:16 UTC
Near three years from the bug was opened. Dear developers would you be so kind and give us some comments or may be fix this bug? I've tried to do it my self, but I'm not skilled enough in ebuild creation.
Comment 15 cyberbat 2013-06-24 13:06:40 UTC
This issue is a big deal for me, so I'm willing to pay USD 10.00 for it. If it break bugzilla rules, than please tell me and I stop publishing such info in bugs that I'm sponsoring.
This offer is registered on FreedomSponsors (http://www.freedomsponsors.org/core/issue/281/mail-clientthunderbird-wrong-lightning-localization).
If you solve it (according to the acceptance criteria described there), please register on FreedomSponsors and mark it as resolved there
I'll then check it out and gladly pay up!

Oh, and if anyone else also wants throw in a few bucks on this, you should check out FreedomSponsors!
Comment 16 Small_Penguin 2013-11-05 19:26:32 UTC
This is still an issue on 24.1.0. Previously, I was able to install the lightning add-on from AMO where the localization files were included, but after updating it now to 2.6.2 this no longer works.

The following solution mentioned above still works:
1) Download corresponding add-on from AMO website.
2) Extract chrome/lightning-<language code>.jar and chrome/calendar-<language code>.jar into /usr/lib/thunderbird/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome.
3) Add the two lines to the chrome.manifest (similar to comment #1).

I believe these steps could be done automatically in install. In fact I have added such steps to my post_install in /etc/portage/bashrc, which I only need to modify slightly before each release so that the URL points to the correct version of the add-on (though I guess there aren't many changes nowadays, at least not for my locale).

Of course, I'd rather like to work on a solution for the ebuild, but this package takes such a f.....g long time to compile...
Comment 17 Small_Penguin 2013-11-06 06:41:35 UTC
Created attachment 362642 [details]
bashrc

In case anyone's interested and find's it useful, here is my bashrc snippet (needs to be in /etc/portage/bashrc) one can use to download the latest AMO lightning xpi package, unzip the locale files and add the appropriate entries to chrome.manifest. It is slightly hackish and may not be 100% error prove, but it should work in most cases and supports multiple locales too.
Comment 18 Small_Penguin 2013-11-06 06:43:42 UTC
You need to alter the lib64 path to lib of course if you're on 32 bit. I guess one could add another check here to see if that target directory exists...
Comment 19 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-06 21:30:33 UTC
Created attachment 362704 [details, diff]
patch to thunderbird-24.1.0-r1 ebuild

This is a patch to the ebuild itself, based on the bashrc script above.  I haven't tested it yet but everything looks like it should work OK.  Let me know how it works.

It's not ideal as it grabs the langpacks from a binary build of lightning -- an ideal solution would generate them, I think.  However, it's certainly better than nothing.
Comment 20 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-07 16:34:49 UTC
Created attachment 362744 [details, diff]
patch to thunderbird-24.1.0-r1.ebuild

Fixed an oops on the install path and the path of chrome.manifest being modified.
Comment 21 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-08 19:12:23 UTC
Created attachment 362804 [details, diff]
patch to thunderbird-24.0.1-r1.ebuild

Final version.  GDATA-Provider has localizations too, so those should also be installed to match LINGUAS when they can.  Also did some various cleanups, made sure mozlinguas was being used properly, etc.

After reviews from other mozilla dev's I'll get this into the tree, perhaps with the next thunderbird version bump.
Comment 22 Daniel Pielmeier gentoo-dev 2013-11-08 19:16:26 UTC
(In reply to Ian Stakenvicius from comment #21)
> Created attachment 362804 [details, diff] [details, diff]
> patch to thunderbird-24.0.1-r1.ebuild
> 
> Final version.  GDATA-Provider has localizations too, so those should also
> be installed to match LINGUAS when they can.  Also did some various
> cleanups, made sure mozlinguas was being used properly, etc.
> 
> After reviews from other mozilla dev's I'll get this into the tree, perhaps
> with the next thunderbird version bump.

Thanks a lot for taking care of this.
Comment 23 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-08 19:18:00 UTC
(In reply to Daniel Pielmeier from comment #22)
> Thanks a lot for taking care of this.

No problem.  that said, since I don't have a system using anything but default locales, if someone that needs these other locales can test and report back that it's all working, I'd appreciate it.
Comment 24 Daniel Pielmeier gentoo-dev 2013-11-08 20:59:43 UTC
(In reply to Ian Stakenvicius from comment #23)
> (In reply to Daniel Pielmeier from comment #22)
> > Thanks a lot for taking care of this.
> 
> No problem.  that said, since I don't have a system using anything but
> default locales, if someone that needs these other locales can test and
> report back that it's all working, I'd appreciate it.

I installed the ebuild with your modifications. Localization of lightning works, but the gdata add-on does not show up in the add-ons manager so google calendars do not work. In previous versions there was a calendar-timezone add-on as well but I think this has been integrated into lightening.
Comment 25 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-08 21:21:35 UTC
(In reply to Daniel Pielmeier from comment #24)
> (In reply to Ian Stakenvicius from comment #23)
> > (In reply to Daniel Pielmeier from comment #22)
> > > Thanks a lot for taking care of this.
> > 
> > No problem.  that said, since I don't have a system using anything but
> > default locales, if someone that needs these other locales can test and
> > report back that it's all working, I'd appreciate it.
> 
> I installed the ebuild with your modifications. Localization of lightning
> works, but the gdata add-on does not show up in the add-ons manager so
> google calendars do not work. In previous versions there was a
> calendar-timezone add-on as well but I think this has been integrated into
> lightening.

Hm; i am having the same issues with gdata-provider not existing by default.  Unsure why, since it's installed properly as far as I can tell..  Do you recall if it was working prior to this patch?
Comment 26 Daniel Pielmeier gentoo-dev 2013-11-08 21:35:17 UTC
There is one bug in the gdata part but it is not responsible for the missing add-on. The local variable c is not defined. It shouldn't be a variable but the string gdata-provider instead.
Comment 27 Daniel Pielmeier gentoo-dev 2013-11-08 21:44:33 UTC
Hm, the google calendars do not work with the unmodified version was well.
Comment 28 Daniel Pielmeier gentoo-dev 2013-11-08 22:07:28 UTC
Found the reason. The em:id for the gdata-provider is wrong it should be a62ef8ec-5fdc-40c2-873c-223b8a6925cc instead of 3550f703-e582-4d05-9a08-453d09bdfdc6. If you rename the extensions directory the provider works.
Comment 29 Daniel Pielmeier gentoo-dev 2013-11-08 22:23:31 UTC
Created attachment 362816 [details, diff]
thunderbird-24.1.0-r2.diff

Attached diff includes a fix for the addition of the locale to chrome.manifest and a quick and dirty fix for the wrong em:id.
Comment 30 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-08 23:06:41 UTC
(In reply to Daniel Pielmeier from comment #29)
> Created attachment 362816 [details, diff] [details, diff]
> thunderbird-24.1.0-r2.diff
> 
> Attached diff includes a fix for the addition of the locale to
> chrome.manifest and a quick and dirty fix for the wrong em:id.

Thanks!

Based on what the code does, I think it would suffice to just swap the old {3550f703-e582-4d05-9a08-453d09bdfdc6} for the new {a62ef8ec-5fdc-40c2-873c-223b8a6925cc} ... no need to extract it in one place and then move it to another, afaict.

Again, will confirm with the rest of mozilla herd and get the ebuild updated.
Comment 31 Jory A. Pratt gentoo-dev 2013-11-09 01:22:12 UTC
(In reply to Ian Stakenvicius from comment #30)
> (In reply to Daniel Pielmeier from comment #29)
> > Created attachment 362816 [details, diff] [details, diff] [details, diff]
> > thunderbird-24.1.0-r2.diff
> > 
> > Attached diff includes a fix for the addition of the locale to
> > chrome.manifest and a quick and dirty fix for the wrong em:id.
> 
> Thanks!
> 
> Based on what the code does, I think it would suffice to just swap the old
> {3550f703-e582-4d05-9a08-453d09bdfdc6} for the new
> {a62ef8ec-5fdc-40c2-873c-223b8a6925cc} ... no need to extract it in one
> place and then move it to another, afaict.
> 
> Again, will confirm with the rest of mozilla herd and get the ebuild updated.

Land it all on mozilla overlay and tree Ian. All looks sane and you have reports of success so you have my go ahead.
Comment 32 Daniel Pielmeier gentoo-dev 2013-11-09 09:26:32 UTC
(In reply to Ian Stakenvicius from comment #30)
> (In reply to Daniel Pielmeier from comment #29)
> > Created attachment 362816 [details, diff] [details, diff] [details, diff]
> > thunderbird-24.1.0-r2.diff
> > 
> > Attached diff includes a fix for the addition of the locale to
> > chrome.manifest and a quick and dirty fix for the wrong em:id.
> 
> Based on what the code does, I think it would suffice to just swap the old
> {3550f703-e582-4d05-9a08-453d09bdfdc6} for the new
> {a62ef8ec-5fdc-40c2-873c-223b8a6925cc} ... no need to extract it in one
> place and then move it to another, afaict.

Even better, I just was not sure if anything else installs there so I renamed the directory afterwards. Again thanks for taking care of this.
Comment 33 Ian Stakenvicius (RETIRED) gentoo-dev 2013-11-11 14:24:14 UTC
+*thunderbird-24.1.0-r2 (09 Nov 2013)
+
+  09 Nov 2013; Ian Stakenvicius <axs@gentoo.org> +thunderbird-24.1.0-r2.ebuild,
+  -thunderbird-24.1.0-r1.ebuild:
+  Add locale support for lightning an gdata-provider, bug 333945
Comment 34 Small_Penguin 2013-11-11 15:52:48 UTC
Thanks for finally fixing this!