Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 332829 - Inconsistency between distro's KDE4WorkspaceConfig.cmake and the actual layout
Summary: Inconsistency between distro's KDE4WorkspaceConfig.cmake and the actual layout
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2010-08-15 11:01 UTC by Ciprian Ciubotariu
Modified: 2011-12-18 00:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciprian Ciubotariu 2010-08-15 11:01:11 UTC
Development on kdevelop4 is hindered by an inconsistency between your distributed libraries and your distributed development files for those libs.

When building kdevelop4 from sources, the following error appears:

/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.3/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lKDE4Workspace__processui

The file that points the build system to search for libKDE4Workspace__processui is /usr/lib64/cmake/KDE4Workspace-4.4.5/KDE4WorkspaceConfig.cmake. Here is the harmful snippet:

set(KDE4WORKSPACE_TARGET_PREFIX KDE4Workspace__)
...
macro(_KDE4WORKSPACE_Set_Lib_Vars _prefix _lib)
  set(KDE4WORKSPACE_${_prefix}_LIBRARY ${KDE4WORKSPACE_TARGET_PREFIX}${_lib})
  set(KDE4WORKSPACE_${_prefix}_LIBS    ${KDE4WORKSPACE_TARGET_PREFIX}${_lib})
endmacro(_KDE4WORKSPACE_Set_Lib_Vars)
...
_kde4workspace_set_lib_vars( PROCESSUI          processui)

I believe the appropriate version for your distro would be:

macro(_KDE4WORKSPACE_Set_Lib_Vars _prefix _lib)
  set(KDE4WORKSPACE_${_prefix}_LIBRARY ${_lib})
  set(KDE4WORKSPACE_${_prefix}_LIBS    ${_lib})
endmacro(_KDE4WORKSPACE_Set_Lib_Vars)

This change will also remove the need for hacks in other ebuilds, such as that mentioned in bug #272829

Reproducible: Always
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2011-04-03 15:18:28 UTC
There's probably only one guy around who really understands this. Adding him.
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2011-08-23 21:59:38 UTC
I put this on the agenda for the next KDE meeting; needs to be discussed.
Comment 3 Johannes Huber (RETIRED) gentoo-dev 2011-11-16 21:18:37 UTC
When i build kdevelop-4.2.3 with cmake-2.8.6 and gcc-4.5.3, can't see such an error. Is this still valid?
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2011-11-16 23:28:20 UTC
(In reply to comment #3)
> When i build kdevelop-4.2.3 with cmake-2.8.6 and gcc-4.5.3, can't see such an
> error. Is this still valid?

Yes it is, I can reproduce it.
Comment 5 Maciej Mrozowski gentoo-dev 2011-11-24 02:41:41 UTC
Hmm, this is actually good idea.

I've commited a change based on this suggestion for field tests in overlay.

http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=085abde8e34fbc3d6e48d15d0d274a0276924c96

Note that libkworkspace needs to be rebuilt afterwards.
Comment 6 Johannes Huber (RETIRED) gentoo-dev 2011-12-04 00:57:17 UTC
Maybe the move of this fix should be done before stabilisation.
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2011-12-18 00:04:50 UTC
Since we have not heard of any major explosions as result of this, the change has been moved to the main tree (combined with a revbump of libkworkspace in all versions).