Bug 332505 – net-p2p/transmission: Fix 'doicon' line from 'qt/icons/' to 'icons/'

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2010-08-12 18:09:08 UTC]

If I install with USE"+qt4" the icon is not compare, i found error and modify ebuild.
So i see same error in other transmission ebuild
See new ebuild. 

Reproducible: Always

[Comment 1 Agostino Sarubbo 2010-08-12 18:11:47 UTC]

Created attachment 242643 [details]
New ebuild

[Comment 2 Samuli Suominen (RETIRED) 2010-08-12 18:15:29 UTC]

What does "USE"+qt4" the icon is not compare" mean? If you install with USE="gtk", the icon is installed in hicolor's icon theme directory.
So the 'doicon' line is in fact correct in all ebuilds.

[Comment 3 Samuli Suominen (RETIRED) 2010-08-12 18:15:38 UTC]

Comment on attachment 242643 [details]
New ebuild

doicon line is correct

[Comment 4 Samuli Suominen (RETIRED) 2010-08-12 18:18:53 UTC]

Or did you mean to change:

use gtk || doicon qt/icons/transmission.png

to:

use gtk || doicon icons/transmission.png

That might be correct...

[Comment 5 Agostino Sarubbo 2010-08-12 18:31:02 UTC]

Created attachment 242647 [details]
New ebuild

I remove use gtk on line 96 because if use qt4 is active, the icon must be present, and I add "|| die" for QA questions

[Comment 6 Agostino Sarubbo 2010-08-12 18:35:37 UTC]

(In reply to comment #2)
> What does "USE"+qt4" the icon is not compare" mean? If you install with
> USE="gtk", the icon is installed in hicolor's icon theme directory.
> So the 'doicon' line is in fact correct in all ebuilds.
> 

If you install with USE="+qt -gtk" the icon do not appear. See here http://yfrog.com/1xsnapshot3vhp

[Comment 7 Enrico Tagliavini 2010-08-12 18:41:03 UTC]

(In reply to comment #2)
> If you install with
> USE="gtk", the icon is installed in hicolor's icon theme directory.
> So the 'doicon' line is in fact correct in all ebuilds.
> 

Currently if you install with USE="gtk qt4" the qt4 icon (transmission.png) is not installed but it is needed by the desktop entry done if use qt4 is used.

[Comment 8 Samuli Suominen (RETIRED) 2010-08-12 19:07:39 UTC]

(In reply to comment #7)
> (In reply to comment #2)
> > If you install with
> > USE="gtk", the icon is installed in hicolor's icon theme directory.
> > So the 'doicon' line is in fact correct in all ebuilds.
> > 
> 
> Currently if you install with USE="gtk qt4" the qt4 icon (transmission.png) is
> not installed but it is needed by the desktop entry done if use qt4 is used.
> 

Nope, it's not required. Any sane desktop environment is able to use the icon from hicolor's icon theme directory:

net-p2p/transmission (/usr/share/icons/hicolor/16x16/apps/transmission.png)
net-p2p/transmission (/usr/share/icons/hicolor/24x24/apps/transmission.png)
net-p2p/transmission (/usr/share/icons/hicolor/22x22/apps/transmission.png)
net-p2p/transmission (/usr/share/icons/hicolor/48x48/apps/transmission.png)
net-p2p/transmission (/usr/share/icons/hicolor/32x32/apps/transmission.png)

[Comment 9 Samuli Suominen (RETIRED) 2010-08-12 19:08:49 UTC]

Comment on attachment 242647 [details]
New ebuild

Still wrong. No doicon is needed with USE="gtk", hicolor icons are used instead.

Futhermore you should provide patches against ebuilds, instead of full ebuilds

[Comment 10 Enrico Tagliavini 2010-08-12 19:26:23 UTC]

(In reply to comment #8)
> Nope, it's not required. Any sane desktop environment is able to use the icon
> from hicolor's icon theme directory:

I'm sorry i thought the qt and gtk icons where different, but they aren't eheheh :)

[Comment 11 Peter Volkov (RETIRED) 2010-08-13 06:50:59 UTC]

Thank you guys. If I read this bug correctly it is invalid )

And hey, new version is available. I'll bump it shortly :)

[Comment 12 Enrico Tagliavini 2010-08-13 22:26:26 UTC]

(In reply to comment #11)
> Thank you guys. If I read this bug correctly it is invalid )
> 
> And hey, new version is available. I'll bump it shortly :)
> 

I think it is not. the doicon path is wrong: on line 92 of the official stable ebuild there is a cd qt and then on line 96 doicon qt/icons/transmission.png and this should be doicon icons/transmission.png . Also a || die is advisable imho :)

[Comment 13 Peter Volkov (RETIRED) 2010-08-16 12:53:34 UTC]

Thank you. Now I see. I'll fix shortly. )

[Comment 14 Peter Volkov (RETIRED) 2010-08-17 18:15:33 UTC]

Fixed in 2.04-r1.