Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 332451 - QA Issues with net-analyzer/pnp4nagios-0.6.4
Summary: QA Issues with net-analyzer/pnp4nagios-0.6.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Tobias Scherbaum (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 330539
  Show dependency tree
 
Reported: 2010-08-12 15:53 UTC by Dane Smith (RETIRED)
Modified: 2010-10-31 15:11 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,77.59 KB, text/plain)
2010-08-12 15:54 UTC, Dane Smith (RETIRED)
Details
Diff from pnp4nagios-0.6.4.ebuild (pnp4nagios.ebuild.diff,831 bytes, text/plain)
2010-08-12 16:30 UTC, Dane Smith (RETIRED)
Details
src/Makefile.in Patch (pnp4nagios-0.6.4-makefile.patch,365 bytes, text/plain)
2010-08-12 16:33 UTC, Dane Smith (RETIRED)
Details
Makefile.in patch (pnp4nagios-0.6.4-stripped.patch,366 bytes, text/plain)
2010-08-12 16:35 UTC, Dane Smith (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dane Smith (RETIRED) gentoo-dev 2010-08-12 15:53:17 UTC
* QA Notice: Pre-stripped files found:
 * /usr/bin/npcd
 * /usr/bin/npcdmod.o

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/npcd

Build.log to follow. I will work on a fix for both if I can.


Portage 2.1.8.3 (default/linux/amd64/10.0/desktop/kde, gcc-4.3.4, glibc-2.11.2-r0, 2.6.34-gentoo-r1 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.34-gentoo-r1-x86_64-Intel-R-_Xeon-R-_CPU_X3210_@_2.13GHz-with-gentoo-2.0.1
Timestamp of tree: Thu, 12 Aug 2010 13:15:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 2.4 [enabled]
app-shells/bash:     4.0_p37
dev-java/java-config: 2.1.11
dev-lang/python:     2.6.5-r3, 3.1.2-r4
dev-util/ccache:     2.4-r7
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.1-r1
sys-apps/sandbox:    1.6-r2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.3.4, 4.4.3-r2
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=nocona -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=nocona -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests ccache distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms strict unmerge-logs unmerge-orphans"
GENTOO_MIRRORS="http://gentoo.mirrors.tds.net/gentoo http://mirror.csclub.uwaterloo.ca/gentoo-distfiles/ http://distro.ibiblio.org/pub/linux/distributions/gentoo/ http://www.cyberuse.com/gentoo/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu,--enable-new-dtags"
LINGUAS="en_US en"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/smithdanea /var/lib/layman/sunrise"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 bash-completion berkdb bluetooth branding bzip2 cairo cddb cdparanoia cdr cli consolekit cracklib crypt cups cvs cxx dbus dri dts dvd dvdr dvdread emboss encode exif fam ffmpeg firefox flac fortran gdbm gif git gphoto2 gpm hal iconv ipod java java6 jpeg kde lame lcms ldap libnotify lm_sensors mad mikmod mmx mng modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl nptlonly nsplugin ogg opengl openmp openssl oss pam pango pcre pdf perl png ppds pppd python qt3 qt3support qt4 quicktime readline reflection sdl session spell spl sse sse2 ssl startup-notification subversion svg sysfs tcpd threads tiff truetype unicode usb v4l v4l2 vcd vorbis x264 xcb xinerama xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard evdev mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_US en" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="nv nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

net-analyzer/pnp4nagios-0.6.4 was built with the following:
USE="(multilib) -apache2"
Comment 1 Dane Smith (RETIRED) gentoo-dev 2010-08-12 15:54:03 UTC
Created attachment 242597 [details]
build.log
Comment 2 Dane Smith (RETIRED) gentoo-dev 2010-08-12 16:30:13 UTC
Created attachment 242631 [details]
Diff from pnp4nagios-0.6.4.ebuild

Diff from the ebuild in the tree. Changed the install target. Attached both the patches.
Comment 3 Dane Smith (RETIRED) gentoo-dev 2010-08-12 16:33:17 UTC
Created attachment 242633 [details]
src/Makefile.in Patch

Added LDFLAGS into the npcd target.
Comment 4 Dane Smith (RETIRED) gentoo-dev 2010-08-12 16:35:46 UTC
Created attachment 242635 [details]
Makefile.in patch

The Makefile.in install-unstripped target calls make install-unstripped in all of the sub-directories. However, the Makefiles SHARE and SCRIPTS do not have such targets. Changed install-unstripped to just call make install in those directories.

I am willing to submit these upstream, but I will wait to hear from the maintainer. I don't want to step on any toes.
Comment 5 Ole Markus With (RETIRED) gentoo-dev 2010-10-13 20:02:09 UTC
Added patches to 0.6.5 as well as some fixes required for PHP 5.3 and commited to the tree as 0.6.5-r1. Seems to be working.
Comment 6 Tobias Scherbaum (RETIRED) gentoo-dev 2010-10-14 07:39:07 UTC
(In reply to comment #5)
> Added patches to 0.6.5 as well as some fixes required for PHP 5.3 and commited
> to the tree as 0.6.5-r1. Seems to be working.
> 

Is not working as important files are no longer installed. 
Comment 7 Tobias Scherbaum (RETIRED) gentoo-dev 2010-10-14 18:47:57 UTC
re-opening and adding olemarkus@gentoo.org to CC.
Comment 8 Tobias Scherbaum (RETIRED) gentoo-dev 2010-10-20 16:37:58 UTC
(In reply to comment #7)
> re-opening and adding olemarkus@gentoo.org to CC.
> 

Congrats to breaking stuff and not reacting after all dude. Tumbsup!

This is now really fixed in CVS.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2010-10-20 16:54:22 UTC
Looks like this happened within the first month. CCing mentor.
Comment 10 Matti Bickel (RETIRED) gentoo-dev 2010-10-20 21:11:12 UTC
Yeah, that's my fault. I only checked the ebuild, sorry for that. Tbh, I wouldn't have caught the error from commit inspection, though.
Anyway, won't happen again. That's no excuse but RL kept me fairly occupied last week(s).

Btw, I'm confused - I only saw the action in Bug 330539? No idea pnp4nagios was broken that long. Sorry for that oversight, too.

OTOH, please be aware that with my RL issues thinning my time for gentoo, Ole is handling all of PHP by himself, which could probably keep half a dozen devs busy.

If there's anything you'd like me to do on this bug, I still try to keep up with my (bug)mail.. so just reply :)
Comment 11 Tobias Scherbaum (RETIRED) gentoo-dev 2010-10-24 12:44:07 UTC
(In reply to comment #10)
> Yeah, that's my fault. I only checked the ebuild, sorry for that. Tbh, I
> wouldn't have caught the error from commit inspection, though.
> Anyway, won't happen again. That's no excuse but RL kept me fairly occupied
> last week(s).

Well, basically ... Ebuilds that tend to look good don't necessarily need to work as expected. Therefore it is absolutely required to check what you're changing, what the impacts are and if the result in the end is still working. The openssl patch in Debian for example did look good, but well ... you know the end.

Even for QA related stuff (btw. i thought only QA people are allowed to commit QA related stuff?) ... test it or don't commit it. Oh, and *if* you screwed up - then at least revert the changes or fix your commits. Neither has happened. And not reacting for now 14 days ... that's also quite bad.

> Btw, I'm confused - I only saw the action in Bug 330539? No idea pnp4nagios was
> broken that long. Sorry for that oversight, too.

Then you should read this bug again.

> OTOH, please be aware that with my RL issues thinning my time for gentoo, Ole
> is handling all of PHP by himself, which could probably keep half a dozen devs
> busy.

Being a mentor and having no time for Gentoo - well that's a combination that's not going to work. Also it isn't that "optimal" to have a new dev being responsible for such important stuff (and especially if his mentor has time constraints).

> If there's anything you'd like me to do on this bug, I still try to keep up
> with my (bug)mail.. so just reply :)

Not sure what to do - that's a recruiters thingy. Adding them therefore.
Comment 12 Petteri Räty (RETIRED) gentoo-dev 2010-10-24 13:03:36 UTC
(In reply to comment #11)
> 
> > If there's anything you'd like me to do on this bug, I still try to keep up
> > with my (bug)mail.. so just reply :)
> 
> Not sure what to do - that's a recruiters thingy. Adding them therefore.
> 

This bug is not the place for this discussion. We should do it in bug 321263.
Comment 13 Tobias Scherbaum (RETIRED) gentoo-dev 2010-10-31 15:11:24 UTC
(In reply to comment #12)
> This bug is not the place for this discussion. We should do it in bug 321263.

Closing this one therefore.