331723 – media-sound/mpd: tweak default log/pid paths

Bug 331723 - media-sound/mpd: tweak default log/pid paths

Summary: media-sound/mpd: tweak default log/pid paths

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Christoph Mende (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-09 08:01 UTC by SpanKY
Modified:	2010-09-10 07:49 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description SpanKY gentoo-dev

2010-08-09 08:01:43 UTC

since mpd only creates one log and one pid file, it should not be given its own subdir.  so the default values should be:

log_file       "/var/log/mpd.log"
pid_file       "/var/run/mpd.pid"

this has the added advantage of the default mpd init.d script working out of the box and not needing immediate tweaking

Comment 1 Christoph Mende (RETIRED) gentoo-dev

2010-09-03 14:14:30 UTC

the problem here is that mpd drops to its own user _before_ creating the pid file, so this results in a permission problem

Comment 2 SpanKY gentoo-dev

2010-09-03 19:24:08 UTC

so fix it.  multiple solutions:
 - fix mpd to open the file before dropping perms
 - use ssd to manage the pid
 - use `checkpath` to create the file with the right perms

Comment 3 Christoph Mende (RETIRED) gentoo-dev

2010-09-10 07:49:52 UTC

+  06 Sep 2010; <angelos@gentoo.org> +mpd-0.15.12-r1.ebuild,
+  +files/mpd.conf.patch, +files/mpd.init:
+  Tweak default pid/log paths (bug #331723), fix init script dependencies
+  (bug #331725), reduce init script noise (bug #331727) and convert init
+  script to s-s-d (bug #331729)