331171 – app-admin/conky-1.8.0-r2: Doesn't compile when USE="-X thinkpad"

Bug 331171 - app-admin/conky-1.8.0-r2: Doesn't compile when USE="-X thinkpad"

Summary: app-admin/conky-1.8.0-r2: Doesn't compile when USE="-X thinkpad"

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Daniel Pielmeier

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-04 08:55 UTC by Marián Čavojský
Modified:	2010-08-13 19:42 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marián Čavojský 2010-08-04 08:55:58 UTC

in text_object.h: 143
#ifdef X11
	OBJ_smapi_bat_bar,
#endif /* X11 */

in conky.c: 2248
			OBJ(smapi_bat_bar) {
				print_smapi_bat_bar(obj, p, p_max_size);
			}

without conditional compilation (#ifdef X11)

Reproducible: Always

Steps to Reproduce:
1.USE="-X thinkpad" emerge -va =app-admin/conky-1.8.0-r2
2.
3.

Actual Results:  
i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -DSYSTEM_CONFIG_FILE=\"/etc/conky/conky.conf\" -DPACKAGE_LIBDIR=\"/usr/lib/conky\"   -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include     -I/usr/include/libxml2   -Wall -W -march=pentium-m -Os -pipe -msse2 -fomit-frame-pointer -MT conky-core.o -MD -MP -MF .deps/conky-core.Tpo -c -o conky-core.o `test -f 'core.c' || echo './'`core.c
conky.c: In function 'generate_text_internal':
conky.c:2248: error: 'OBJ_smapi_bat_bar' undeclared (first use in this function)


Expected Results:  
compilation ok.

Comment 1 Brenden Matthews 2010-08-13 17:59:53 UTC

Fix:

http://git.omp.am/?p=conky.git;a=commit;h=a25985f00b5956e1100900a50986fd89ff560812

Comment 2 Daniel Pielmeier gentoo-dev

2010-08-13 19:42:12 UTC

+  13 Aug 2010; Daniel Pielmeier <billie@gentoo.org> conky-1.8.0-r2.ebuild:
+  Add patch to fix bug #331171. Thanks to Marián Čavojský for the report
+  and Brenden Matthews for the fix. Also fixes other issues related to
+  USE="-X".