Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 330801 - games-strategy/warzone2100: excessive redownload during package updates. Please change the src_uri in ebuild
Summary: games-strategy/warzone2100: excessive redownload during package updates. Plea...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Games
URL: http://wz2100.net/download
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-02 08:40 UTC by Sergey Kondakov
Modified: 2010-08-12 19:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Kondakov 2010-08-02 08:40:06 UTC
due to bug 317283 src_uri was changed to include better in-game videos like this:

VIDEOS_P=${P}-videos.wz
SRC_URI="mirror://sourceforge/warzone2100/${P}.tar.gz
        videos? ( mirror://sourceforge/warzone2100/warzone2100/Videos/2.2/high-quality-en/sequences.wz -> ${VIDEOS_P} )"

and it's pretty damn ridiculous because you're forced to redownload same Half-Gigabyte file on each update.

it should have been like:

VIDEOS_PN=${PN}-videos.wz
SRC_URI="mirror://sourceforge/warzone2100/${P}.tar.gz
        videos? ( mirror://sourceforge/warzone2100/warzone2100/Videos/2.2/high-quality-en/sequences.wz -> ${VIDEOS_PN} )"

you need only one of these for any version of the game and it not like this file is going to change any time soon or ever.

Reproducible: Always

Steps to Reproduce:
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2010-08-02 15:40:02 UTC
No.  The file needs to be versioned.  You can complain to upstream about not having sane naming conventions for their files.  If you aren't comfortable downloading the file you can rename it locally in the meantime.
Comment 2 Harald van Dijk (RETIRED) gentoo-dev 2010-08-02 18:19:21 UTC
Yes, the file name should be versioned, but the way it's done isn't right, because video versioning is completely separate from the code versioning. On the mirrors, the video file names should use the video version, and this would address both this bug and your reason for closing it as WONTFIX.

VIDEOS_P=${P}-videos.wz

could be changed to simply

VIDEOS_P=${PN}-videos-2.2.wz

where 2.2 is the video version number, as seen in the video SRC_URI.
Comment 3 Sergey Kondakov 2010-08-03 23:42:15 UTC
what a nonsense - 2.2 is not even a version of the video, it's a version of the game where support of the in-game video was added first! (http://developer.wz2100.net/changeset/6119)
and "2.2" where only because it was convenient for developers to put it under the minimum version required for it to work.

169.6 MB file is original quality videos from PS1 times,
571.9 MB file is better quality version taken from some developer just recently.

and videos have no ties to versions of the game, its quite the other way around, so it has no damn sense to version videos by game versions even if you think that they going to be changed for some reason.

if you really desire versioning for something you don't know how to version and why - "2.2" is a killer choice, but redownloading same Giang thing on code updates without it actually depending on those code updates is silly. no, sir!
Comment 4 Harald van Dijk (RETIRED) gentoo-dev 2010-08-04 06:06:40 UTC
Not sure what your problem is. The video is currently in a /2.2/ subdirectory, and if a video update would be released (however unlikely) with the same filename, it would have to live in a different subdirectory, quite probably again using a version number as a directory name. In all the ways that matter, that makes 2.2 the video version number.
Comment 5 Sergey Kondakov 2010-08-12 16:42:09 UTC
i don't have problem with "2.2", i have problem with the way it is right now.

i just don't get whole "The file needs to be versioned" thing even though we taking those "versions" out of the thin air. and in a verge of silliness - "versioning" the same damn file over and over again...
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2010-08-12 19:08:16 UTC
fixed.  thanks for the bug report.