Bugzilla Bug 33067

some cleanups for the pvm-ebuild -- it improves (I hope) the one submitted in
bug
#24197:
- replaced duplicate install-dir references with one variable (PVM_ROOT).
- changed destdir from /usr/local/pvm3 to /usr/share/pvm3 (/usr/local should
not
  be filled with portage-controlled stuff I guess).
- patch replaced by epatch

Reproducible: Always
Steps to Reproduce:

Created an attachment (id=20464) [edit]
patch against pvm-3.4.4-r1.ebuild

Could you fix this to use tabs instead of spaces? The whole env.d section
is spaces.

Also replace the name and version in the epatch with ${P}, so it doesn't
require editing every version bump.

Is there any reason for /usr/share/pvm3 instead of /usr/share/pvm?

And creation of the env.d file should take place at ${T}/98pvm. No need for
the touch either.

I just cleaned up the ebuild, please take my changes into consideration before
submitting another patch. Thanks.

the spaces were due to pasting, sorry.

beside that I overlooked the hardcoded version and only switched to epatch its unlikely that there will be a new version of pvm -- but who knows ...

/usr/share/pvm3 is commonly used to I thought it would be a good idea to leave that -- /usr/local is not the correct place imho.

don't understand the ${T} stuff.

don't have the time to deal with this -- switch to fixed if you want.

take care,
thomas

I agree on moving away from /usr/local. If pvm3 is typical instead of pvm, that
sounds fine. ${T} is a temporary directory in /var/tmp/portage, you can read
more in man 5 ebuild. I don't have enough time right now to make these fixes,
that's why I asked you to submit another patch.

If anyone else wants to "port" the changes in the old patch to the current
ebuild, feel free. Otherwise I'll get back to it in a while.

I have installed pvm and pvm-povray-3.1g
pvm-3.4.4-r1 install in /usr/local/pvm3    is correct ?
pvm-3.4.4-r1 set in env.d the file 98pvm with PVM_ROOT and PVM_ARCH
but when installing pvm-povrayg-3.1g the ebuild search PVMROOT and not installing.
There are 2 solution: add PVMROOT on env.d/98pvm or correct the ebuild
I propose the 2nd solution.

Created an attachment (id=26723) [edit]
Correct variable

In ebuild attachment is correct also PVM_ARCH variable

Created an attachment (id=26724) [edit]
Sorry ! This is correct

correct: the current pvm-3.4.4-r1.ebuild installs to /usr/local (the patch in
this
bug would change this to /usr/share/pvm3).

for some reason pvm-povray uses PVMROOT instead of PVM_ROOT (only the latter is
documented in pvm_intro(1PVM)).

the attached ebuild (#9) is for pvm-povray -- not for pvm itself.

if there is other pvm-enabled software out there that uses PVMROOT it may make
sense to add this variable as some kind of "alias" to /etc/env.d/98pvm?

This is extract for doc pvm-povray:

1.4. Building PVMPOV

After the patch has been applied successfully you can build the PVMPOV binaries. Change into the povray31/source/pvm directory and type 

This is extract for doc pvm-povray:

1.4. Building PVMPOV

After the patch has been applied successfully you can build the PVMPOV binaries. Change into the povray31/source/pvm directory and type “aimk newunix”. (“aimk” is a wrapper program for “make”, used to portably select options to build PVM and PVM applications on various machines. “aimk” is part of the PVM suite.) When the compilation finishes, compile the display capable versions of PVMPOV by executing “aimk newsvga” and “aimk newxwin”. The binaries will then be in povray31/sources/pvm/$PVM_ARCH.

When the compilation failes, make sure, that you have set up PVM correctly (i.e.: that the environment variables PVMROOT and PATH fit your requirements.) 

1.5. Installing the binaries

As the case may be, the PVMPOV binaries can be installed in lots of ways.

    * If you can get administrative rights, then do the following:

$ su -
$ cd /home/flierl/tmp/pvmpov3_1g_2/povray31/source/pvm
$ aimk install

      This will copy the binaries to $PVM_ROOT/bin/$PVM_ARCH and create symbolic links in /usr/local/bin.
    * If you cannot get “root” you have two other options:
         1. Move the binaries into $HOME/pvm3/bin/$PVM_ARCH.
         2. Use the “ep=$PATH” option in your pvm.hosts file. Read the PVM documentation for more information. 

For me PVM_ROOT is correct and PVMROOT it is an error.

because in portage the pvm-3.4.4-r1 is old. The patch is not applicate?

Created an attachment (id=26732) [edit]
This is ebuild in portage

Because this ebuild ??

Also xpvm ebuils with PVM_ROOT=/usr/local/pvm3 !!!
Where is correct !!!???

I propose to correct only the variable PVM_ROOT and PVM_ARCH in the ebuid for
pvm-povray

Antonio,
at the moment all the pvm-ebuilds (both pvm itself and xpvm) install to
/usr/local/pvm -- the suggestion I made in bug you are reading comments in is to
change this to /usr/share/pvm3. But that change has not happend yet (maybe it will
never happen -- no offense meant).

what i wanted to say is that maybe you are commenting the wrong bug: if pvm-povray
uses non-existing (and regarding PVM itself undocumented) variables it's a problem
of the pvm-povray-ebuild and not of the pvm-ebuild.

Thomas

you have reason Sorry 
I open the bug for pvm-povray
Thanks

Antonio

Okay, so what about this bug?

Should we change the install path to /usr/share/pvm3 or leave it as is?

Thomas? Comments?

yep: s@/usr/local/pvm3@/usr/share/pvm3@g.
The environment-stuff is already in -- no new patch attached as the changes are
trivial (3 occurences).

I fixed this in pvm-3.4.4-r2. Please file another bug for any issues with
pvm-povray.

Thanks for the contribution and sorry about the delay.