Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 330211 - dev-lang/icc QA violation with restrictions
Summary: dev-lang/icc QA violation with restrictions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 13:06 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-11-26 16:05 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-28 13:06:27 UTC
I just removed binchecks restriction from your package. That was a *nasty* QA violation: if your package have textrels and other problems you _should_ declare them in the ebuild, not restrict the sanity checks!

Also please verify that the RESTRICT=strip is warranted and you're not just trying to bail out of using QA_PRESTRIPPED.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2010-11-26 13:16:45 UTC
I clean ed this up and removed the stirp RESTRICT.
Comment 2 Sébastien Fabbro (RETIRED) gentoo-dev 2010-11-26 15:59:12 UTC
@@ -32,17 +32,6 @@
 	eclipse? ( >=dev-util/eclipse-sdk-3.4 )"
 
 DESTINATION="opt/intel/Compiler/${RELEASE}/${BUILD}"
-EDESTINATION="${EROOT#/}${DESTINATION}"
-
-QA_TEXTRELS="${EDESTINATION}/*"
-QA_EXECSTACK="${EDESTINATION}/*"
-QA_PRESTRIPPED="${EDESTINATION}/lib/*/.*libFNP.so ${EDESTINATION}/bin/*/.* ${EDESTINATION}/idb/*/*/.*"
-QA_DT_HASH="
-	${EDESTINATION}/bin/*/.*
-	${EDESTINATION}/lib/*/.*
-	${EDESTINATION}/mkl/lib/*/.*
-	${EDESTINATION}/mkl/benchmarks/mp_linpack/bin_intel/*/.*
-	${EDESTINATION}/idb/*/*/.*"

Which comes pretty close to RESTRICT=binchecks
I am not quite convinced of the utility of the QA_* in the case of the Intel libs and compilers. Upstream ignores us completely and the QA problems changes every release.

Also for binary only packages in the case of QA_PRESTRIPPED, calling it a QA problem is a bit stretched.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-26 16:05:01 UTC
I'm actually quite positive toward having a

QA_PREBUILT_WE_CANT_DO_FUCK_ABOUT

but you should talk to Zac about that :)