Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 329823 - sys-boot/gnu-efi-3.0i - multiple QA issues
Summary: sys-boot/gnu-efi-3.0i - multiple QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High QA (vote)
Assignee: IA-64 team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 329715
  Show dependency tree
 
Reported: 2010-07-25 20:28 UTC by Dane Smith (RETIRED)
Modified: 2012-11-25 04:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild diff for gnu-efi-3.0i (gnu-efi-3.0i.diff,594 bytes, text/plain)
2010-07-25 20:42 UTC, Dane Smith (RETIRED)
Details
Patch for crt0-efi-ia32.S (gnu-efi-3.0i-crt0.diff,418 bytes, text/plain)
2010-07-25 20:45 UTC, Dane Smith (RETIRED)
Details
Patch for setjmp_i32.S (gnu-efi-3.0i-setjmp.diff,357 bytes, text/plain)
2010-07-25 20:46 UTC, Dane Smith (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dane Smith (RETIRED) gentoo-dev 2010-07-25 20:28:49 UTC
* QA Notice: command not found:
 * 
 *      /var/tmp/portage/sys-boot/gnu-efi-3.0i/temp/environment: line 2280:
filterdiff: command not found
strip: i686-pc-linux-gnu-strip --strip-unneeded -R .comment
   usr/lib/crt0-efi-ia32.o
   usr/lib/libefi.a
   usr/lib/libgnuefi.a

 * QA Notice: The following files contain writable and executable sections
 *  Files with such sections will not work properly (or at all!) on some
 *  architectures/operating systems.  A bug should be filed at
 *  http://bugs.gentoo.org/ to make sure the issue is fixed.
 *  For more information, see http://hardened.gentoo.org/gnu-stack.xml
 *  Please include the following list of files in your report:
 *  Note: Bugs should be filed for the respective maintainers
 *  of the package in question and not hardened@g.o.
 * !WX --- --- usr/lib/libgnuefi.a:setjmp_ia32.o
 * !WX --- --- usr/lib/crt0-efi-ia32.o
Comment 1 Dane Smith (RETIRED) gentoo-dev 2010-07-25 20:42:34 UTC
Created attachment 240139 [details]
Ebuild diff for gnu-efi-3.0i

Will use the following patches.
Comment 2 Dane Smith (RETIRED) gentoo-dev 2010-07-25 20:45:34 UTC
Created attachment 240141 [details]
Patch for crt0-efi-ia32.S

Fixes the first of the QA Warnings.
Comment 3 Dane Smith (RETIRED) gentoo-dev 2010-07-25 20:46:08 UTC
Created attachment 240143 [details]
Patch for setjmp_i32.S

Fixes the second of the QA Warnings.
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2010-08-13 06:07:11 UTC
ia64, can you go on and proceed with the fixes (or at least review them)?
Comment 5 SpanKY gentoo-dev 2010-08-13 15:23:46 UTC
if the EFI objects are only used in low level boot code (i.e. outside of Linux), then adding gnu stack markers to the objects doesnt make sense
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2010-08-15 06:31:26 UTC
(In reply to comment #5)
> if the EFI objects are only used in low level boot code (i.e. outside of
> Linux), then adding gnu stack markers to the objects doesnt make sense

 So  what would be a proper solution here?
Comment 7 SpanKY gentoo-dev 2010-08-15 06:32:26 UTC
if the .o are only used low level and not under Linux, then they should get a QA_xxx exemption in the ebuild
Comment 8 Thomas Kahle (RETIRED) gentoo-dev 2011-01-02 10:21:33 UTC
Soe the proposed solution is to 

-) include DEPEND="dev-util/patchutils"
-) add QA_EXECSTACK="libgnuefi.a:setjmp_ia32.o crt0-efi-ia32.o" to the ebuild.

maintainers, please do, or tell me to do it myself.
Comment 9 SpanKY gentoo-dev 2012-11-25 04:26:08 UTC
should be all set now in the tree; thanks for the report!

Commit message: Disable QA checks on compiled objects as they do not make sense for bootloaders
http://sources.gentoo.org/sys-boot/gnu-efi/gnu-efi-3.0s.ebuild?rev=1.1