Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 329153 - sys-devel/make-3.81-r2 fails test (features/recursion)
Summary: sys-devel/make-3.81-r2 fails test (features/recursion)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 18:47 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2010-07-25 14:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info =sys-devel/make-3.81-r2 (emerge-ino,6.18 KB, text/plain)
2010-07-20 19:08 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details
tests/work/features/recursion.diff (recursion.diff,3.57 KB, text/plain)
2010-07-20 19:13 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details
Upstream fix (make-3.81-recursion-test.patch,530 bytes, patch)
2010-07-25 11:10 UTC, tka
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2010-07-20 18:47:44 UTC
My guess is its an error in the testsuite code, 

features/quoting ........................................ ok     (1 passed)
features/recursion ...................................... Error running /tmp/portage/sys-devel-make-3.81-r2/work/make-3.81/tests/../make (expected 0; got 512): /tmp/portage/sys-devel-make-3.81-r2/work/make-3.81/tests/../make -f work/features/recursion.mk CFLAGS=-O -w-j 2
FAILED (1/2 passed)
features/reinvoke ....................................... ok     (4 passed)

....

work/features/recursion.diff
---
--- 1,43 ----
! /tmp/portage/sys-devel-make-3.81-r2/work/make-3.81/tests/../make: invalid option -- '-'
! Usage: make [options] [target] ...
! Options:


scripts/features/recursion
----
              ('CFLAGS=-O -w' . ($parallel_jobs ? '-j 2' : '')),



Editing this line in the recursion test script to have a space before the  -j 

causes the test to then pass.
ie:
              ('CFLAGS=-O -w' . ($parallel_jobs ? ' -j 2' : '')),


Will attach various build logs and stuff unless somebody deems them not needed before I get a round tuit.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-20 18:55:01 UTC
Please post your `emerge --info =sys-devel/make-3.81-r2' and reopen this bug report.
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2010-07-20 19:08:28 UTC
Created attachment 239587 [details]
emerge --info =sys-devel/make-3.81-r2

emerge --info     contents. 
Nb, may be slightly incorrect in places due to that pesky paludis thing. Paludis equivalent here for those who want it ( I don't want to clutter b.g.o with its massive logs, people have enough hate already ):  https://gist.github.com/412afc5b8950d1118260
Comment 3 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2010-07-20 19:13:00 UTC
Created attachment 239589 [details]
tests/work/features/recursion.diff

Diff from the testsuite.
Comment 4 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2010-07-20 19:15:37 UTC
More information provided.
Comment 5 tka 2010-07-25 11:10:09 UTC
Created attachment 240091 [details, diff]
Upstream fix

The test is fixed upstream: https://savannah.gnu.org/bugs/index.php?29968
Comment 6 SpanKY gentoo-dev 2010-07-25 14:36:46 UTC
thanks, added that patch to the tree