Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 326939 - dev-util/pkgconfig: pkg.m4 installs macro incompatible with autoconf-2.66
Summary: dev-util/pkgconfig: pkg.m4 installs macro incompatible with autoconf-2.66
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-04 23:03 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-07-15 08:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-04 23:03:21 UTC
configure:6275: error: possibly undefined macro: AS_MESSAGE_LOG_FDdnl
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

from configure:

Alternatively, you may set the environment variables GLIB_CFLAGS
and GLIB_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details." "$LINENO" AS_MESSAGE_LOG_FDdnl

from pkg.m4:

        m4_default([$4], [AC_MSG_ERROR(
[Package requirements ($2) were not met:

$$1_PKG_ERRORS

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

_PKG_TEXT])dnl

it needs a whitespace before the dnl...
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-07-05 08:07:02 UTC
i'm not sure if we should fix this is pkg-config, or if this is another regression of autoconf itself...
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-07-05 08:07:35 UTC
(In reply to comment #1)
> i'm not sure if we should fix this is pkg-config, or if this is another
> regression of autoconf itself...
> 

s/is/in/  :)
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2010-07-11 12:28:59 UTC
+*pkgconfig-0.25-r2 (11 Jul 2010)
+
+  11 Jul 2010; Samuli Suominen <ssuominen@gentoo.org>
+  +pkgconfig-0.25-r2.ebuild, +files/pkgconfig-0.25-dnl.patch:
+  Fix for sys-devel/autoconf-2.66 compat (but commit unkeyworded until it's
+  sorted out).
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-11 12:38:04 UTC
Hrm, the fedora patch looks reversed, and on the other hand I'm not sure if _dropping_ dnl is going to be the right thing to do. To me it looks a lot more like it's an autoconf bug...
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-07-11 12:40:28 UTC
that's why it's not keyworded :)  waiting for upstream consensus.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-07-15 07:34:50 UTC
alternative patch,

http://repos.archlinux.org/wsvn/packages/pkg-config/trunk/autoconf-2.66.patch
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2010-07-15 07:39:12 UTC
And the upstream pkg-config bug/patch that likely introduced this regression:

http://bugs.freedesktop.org/show_bug.cgi?id=13892
Comment 9 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-15 07:40:12 UTC
Archlinux wins. That patch is proper, and we could very well be applying it just to be on the safe side.

The problem is that all the packages bundling pkg.m4 will have the same problem.
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2010-07-15 08:08:47 UTC
(In reply to comment #9)
> Archlinux wins. That patch is proper, and we could very well be applying it
> just to be on the safe side.

applied in tree

> The problem is that all the packages bundling pkg.m4 will have the same
> problem.
> 

will keep my eyes open...
Comment 11 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-15 08:15:59 UTC
You do know that we're talking of about 60% of the pkg-config users in the tree, right?
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2010-07-15 08:21:29 UTC
(In reply to comment #11)
> You do know that we're talking of about 60% of the pkg-config users in the
> tree, right?
> 

I've seen it couple of times, but no idea on numbers...

Perhaps tinderbox could run a custom pkg_ function and execute `find` pkg.m4 for ${WORKDIR} or ${S} in it?
Comment 13 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-15 08:25:11 UTC
Sure I could... but at that point I'd rather ask for Zac to write me some code to simply run the unpack/prepare phase of all the packages and check for the pkg.m4 file with the mistake in it ;P
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2010-07-15 08:27:13 UTC
http://bugs.freedesktop.org/show_bug.cgi?id=13892 was applied *after* 0.23
release, so the regression should be only in bundled 0.24 or 0.25 pkg.m4 files.
Comment 15 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-07-15 08:34:25 UTC
Hm okay then it is feasible, I guess, sorry for the extra noise