Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 326333 - app-backup/bacula[postgres] should probably depend on postgresql-base instead of postgresql-server
Summary: app-backup/bacula[postgres] should probably depend on postgresql-base instead...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 15:51 UTC by Karl Hakimian
Modified: 2010-07-22 15:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Hakimian 2010-06-30 15:51:09 UTC
A user wishing to have the database on another machine, should not have to install the postgres server to get bacula. This might make the most sense when the directory is not being compile (bacula-nodir use flag), but really should be an option no matter what.

Reproducible: Always

Steps to Reproduce:
1.emerge bacula with postgres useflag

Actual Results:  
Pulls in postgresql-server

Expected Results:  
Should not require postgresql-server, but probably just postgresql-base.
Comment 1 Thomas Beierlein gentoo-dev 2010-07-21 19:37:12 UTC
While technically it can be done I do not like the idea.

We could 

1. only depend on postgresl-base and leave it to the user to postinstall the server if he needs it (likely case). 
2. Add an additional USE flag to the already long list and that only for the case that you use postgresql.

Both variants are neither simple nor elegant from developers and also from users point of view. 

Any better ideas around?
Comment 2 Aaron W. Swenson gentoo-dev 2010-07-21 20:09:59 UTC
Depend upon what you need. Bacula does not require the PostgreSQL server to be present and running on the same machine.

It does, however, require that dev-db/postgresql-base to be built with the 'threads' USE flag enabled.

From their documentation:

"If you configure the Batch Insert code in Bacula (attribute inserts are 10 times faster), you must be using a PostgreSQL that was built with the --enable-thread-safety option, otherwise you will get data corruption."
Comment 3 Thomas Beierlein gentoo-dev 2010-07-22 11:29:56 UTC
(In reply to comment #2)
> Depend upon what you need. Bacula does not require the PostgreSQL server to be
> present and running on the same machine.

Right. Had some discussion with the postgresql herd about it. Will do the change as suggested by you.

> It does, however, require that dev-db/postgresql-base to be built with the
> 'threads' USE flag enabled.

That is no problem. Thanks for the hint.

Comment 4 Thomas Beierlein gentoo-dev 2010-07-22 13:19:59 UTC
(In reply to comment #3)

> 
> > It does, however, require that dev-db/postgresql-base to be built with the
> > 'threads' USE flag enabled.
> 
> That is no problem. Thanks for the hint.
> 

I am wrong. Seems it is a problem atm as postgresql-base cannot be built with USE=threads (see Bug #300964). 

So I have to disable the batch insert for postgres for the moment.
Comment 5 Thomas Beierlein gentoo-dev 2010-07-22 15:53:45 UTC
After further discussions with postgresql herd USE=threads should be safe and working. Fixed in new revision.

+*bacula-5.0.2-r2 (22 Jul 2010)
+
+  22 Jul 2010; Thomas Beierlein <tomjbe@gentoo.org> +bacula-5.0.2-r2.ebuild,
+  +files/5.0.2/bacula-5.0.2-Makefile.patch,
+  +files/5.0.2/bacula-5.0.2-ldflags.patch:
+  - fix for bug #291160, #322181 and #326333
+  - add vimfiles
+  - make 'bat' respect LDFLAGS
+  - let 'make' fail if some error emerges in a subdir build
+