Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 326101 - dev-util/meld: Verify and potentially improve Python-related code
Summary: dev-util/meld: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-06-29 07:02 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-10-17 20:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-29 07:02:45 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-10-13 20:36:41 UTC
+  13 Oct 2010; Gilles Dartiguelongue <eva@gentoo.org> meld-1.4.0.ebuild:
+  Improve support of python eclass, bug #326101.

Should be fine now. Thanks for reporting.
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-15 21:32:02 UTC
You should call 'python_set_active_version 2' instead of directly setting an internal variable (PYTHON_ABI).
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-17 20:22:41 UTC
(In reply to comment #2)

Clarification: PYTHON_ABI variable is public for reading and private for setting.
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-10-17 20:23:06 UTC
+  17 Oct 2010; Gilles Dartiguelongue <eva@gentoo.org> meld-1.4.0.ebuild:
+  Fix python eclass usage, per Arfrever comments, bug #326101.

Thanks for the update.