Also fixes bug #310961 Reproducible: Always
Created attachment 236445 [details] ebuild, works fine for me
Created attachment 236511 [details, diff] cgit-0.8.3.2.ebuild.patch Practically same as above but with changes as we discussed at IRC (dropped ebegin...eend and dodir before keepdir is redundant).
What's the point of cgit user? Also you changed owner of /var/cache/cgit to cgit:apache, which is going in the right direction, but you haven't given write permissions to apache (chmod g+w /var/cache/cgit/). Or did you have in mind suexec? Then what does apache group has to do with it? In a word, I don't see the logic.
http://hjemli.net/git/cgit/tag/?id=v0.8.3.3 0.8.3.3 has been released
Renaming ebuild works. Builds and runs fine for amd64 and x86. >What's the point of cgit user? Each daemon has it's own user for better security. >but you haven't given write permissions to apache Why should I? http server (I use nginx) does not need to write to or read from this dir. cgit makes files in cache readable only for it's user and works fine. Do you have any problems with your http servers and my ebuild?
Well, apache by default runs CGI scripts without changing uid. I don't know any web app in portage that requires to use its own user. Anyway, there are 2 options: 1). run cgit using web server's user, then web server must have write access to /var/cache/cgit and no "cgit" user is required; 2). run it using "cgit" user, then we should print some notice about that and/or provide example of configuring web servers. Or, better yet, we should allow user to choose. Then we should add smth like this to ebuild: pkg_postinst() { elog "If you intend to run cgit using web server's user (that's default) you should run chmod g+w /var/cache/cgit/ for caching feature of cgit to work." elog "Or you can use provided 'cgit' user." }
Created attachment 245209 [details] new version, fixed cache perms, added ewarn
Looks OK. I suggest committing it to portage ASAP, because current ebuild there is flawed.
(In reply to comment #8) > Looks OK. I suggest committing it to portage ASAP, because current ebuild there > is flawed. > I will take a look as soon as I can. $REALJOB is keeping me busy unfortunately. Thanks for all the feedback!
cgit user is silly idea imho.
Alos this ebuild is flawed even more as it doesn't support webapp-config properly (pkg_setup was removed) - please take care of those before it's considered to tree.
No, it wasn't, it's the first function in ebuild.
Created attachment 247337 [details] fix doc use flag
Maciej, please read ebuilds carefully and avoid doing mistaken comments: grep -e webapp_ -e setup cgit-0.8.3.2.ebuild -A1 pkg_setup() { webapp_pkg_setup enewuser "${PN}" -- Ebuild in portage is broken for 6 months almost as much as possible, it also does not support upgrading or downgrading cgit (/usr/share/man/man5/cgitrc.5 collision).
Lance, are you ok with suggested ebuild by Nikoli? Could you commit or give me ok, please.
Created attachment 248794 [details] new version
Added to rion overlay: http://code.google.com/p/rion-overlay/source/browse/www-apps/cgit
v0.8.3.5 and v0.9 have been released
0.8.3.5 and 0.9 are in overlay now. ebuild in portage is broken for 13 months, Lance, if you have no time for it, why you do not change metadata to maintainer-wanted?
Would be nice to have it in the portage tree without having to use overlay!
Another half of year. Lance I've commited ebuilds by Nikoli. If there are any problems with them, please, contact me. New version is in the tree. Thank you Nikoli!
