Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 324711 - media-plugins/gst-plugins-jack (new package)
Summary: media-plugins/gst-plugins-jack (new package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
: 210216 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-19 16:41 UTC by Angelo Arrifano (RETIRED)
Modified: 2010-12-20 19:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Initial gst-plugins-jack ebuild (gst-plugins-jack-0.10.18.ebuild,369 bytes, text/plain)
2010-06-25 16:38 UTC, Mart Raudsepp
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo Arrifano (RETIRED) gentoo-dev 2010-06-19 16:41:22 UTC
With media-sound/jack-audio-connection-kit-0.118.0 installed I was trying to get jack sink on gstreamer to work. For that I first emerged media-libs/gst-plugins-bad-0.10.17 which at some point showed:

configure: *** checking feature: Jack ***
configure: *** for plug-ins: jack ***
configure: *** These plugins will not be built: jack

which is strange given that I have jack installed.
By inspecting configure.ac, we have:

dnl *** Jack ***
translit(dnm, m, l) AM_CONDITIONAL(USE_JACK, true)
AG_GST_CHECK_FEATURE(JACK, Jack, jack, [
  PKG_CHECK_MODULES(JACK, jack >= 0.99.10, HAVE_JACK="yes", HAVE_JACK="no")
  AC_SUBST(JACK_CFLAGS)
  AC_SUBST(JACK_LIBS)
])

So it checks for the jack.pc which I do have:

Name: jack
Description: the Jack Audio Connection Kit: a low-latency synchronous callback-based media server
Version: 0.118.0

The required version by gst-plugins-bad (0.99.10) is also lower than the installed version. So, why is configure failing to detect jack? It must be the AG_GST_CHECK_FEATURE macro, I guess.

- -

Since I'm with my hands on this bug already, I take the opportunity to ask what do you guys think of adding a jack USE flag to this package? I'll give you a reason and an example I think it would be useful.

1) Users might not know that jack sink is provided by gst-plugins-bad (but easily verifiable on http://www.gstreamer.net/documentation/plugins.html)

2) Suppose a user has the jack USE flag disabled and no jack installed on the system at the time he install gst-plugins-bad. Later the user enables the flag, and installs jack. Since the user wants the system to support jack, he does an emerge --newuse world. Then packages are rebuilt and start supporting jack, except gst-plugins-bad because it doesn't have the jack use flag.
Of course this doesn't only apply to jack.

Regards,
- Angelo
Comment 1 Mart Raudsepp gentoo-dev 2010-06-20 16:38:29 UTC
tl;dr, but we have splitted gstreamer packages, and all of those that are shipped in gstreamer tarballs ext/ or sys/ directories are packaged in split packages. gst-plugins-jack package simply hasn't been created yet, because no-one has requested it that also would have been willing to work with me on getting it tested before inclusion (as I don't have any jack stuff set up). I can provide a package ebuild to test out, and once you or someone confirms all of the provided elements by the plugin work, I can add it to gx86 and keep blindly bumping it, hoping any problems to be reported.
Comment 2 Angelo Arrifano (RETIRED) gentoo-dev 2010-06-20 19:50:28 UTC
(In reply to comment #1)
(...)
> gst-plugins-jack package simply hasn't been created yet, because
> no-one has requested it that also would have been willing to work with me on
> getting it tested before inclusion (as I don't have any jack stuff set up). I
> can provide a package ebuild to test out, and once you or someone confirms all
> of the provided elements by the plugin work, I can add it to gx86 and keep
> blindly bumping it, hoping any problems to be reported.
> 

Sounds like a plan, I'm willing to help you on this one.
Comment 3 brendan 2010-06-25 11:54:14 UTC
(In reply to comment #2)
> (In reply to comment #1)
> (...)
> > gst-plugins-jack package simply hasn't been created yet, because
> > no-one has requested it that also would have been willing to work with me on
> > getting it tested before inclusion (as I don't have any jack stuff set up). I
> > can provide a package ebuild to test out, and once you or someone confirms all
> > of the provided elements by the plugin work, I can add it to gx86 and keep
> > blindly bumping it, hoping any problems to be reported.
> > 
> 
> Sounds like a plan, I'm willing to help you on this one.
> 
I am more then willing to help where I can.
I use Jack a fair bit.
Comment 4 Mart Raudsepp gentoo-dev 2010-06-25 16:38:45 UTC
Created attachment 236533 [details]
Initial gst-plugins-jack ebuild

Please give this a try for both input and output (if possible) and report what architecture you tested on (for initial keywording).
I'm kind of stuck on figuring out a good DESCRIPTION :)
Comment 5 Angelo Arrifano (RETIRED) gentoo-dev 2010-06-25 22:32:21 UTC
During emerge just spotted a QA notice:
 * QA Notice: Unrecognized configure options:
 * 
 * 	configure: WARNING: unrecognized options: --disable-ivorbis
 * 	configure: WARNING: unrecognized options: --disable-ivorbis

Now a few notes:

- Jack sink and source isn't automatically listed on gstreamer-properties. To enable it by default one should do:

$ gst-inspect  | grep jack
jack:  jackaudiosrc: Audio Source (Jack)
jack:  jackaudiosink: Audio Sink (Jack)

Then on gstreamer-properties set audio outputplugin  as "custom" and write "jackaudiosink" on pipeline field, set audio input plugin as "custom" and write "jackaudiosrc" on pipeline field.

Using steps above I could have audio I/O:
Mic -> ALSA -> Jack Server -> Gstreamer
Gstreamer -> Jack Server -> ALSA -> Speakers

I also tested with Quodlibet playback and putting a Jack Effects Rack in the middle. Everything works beautiful.

Thanks for putting this on the tree. If you will, I can touch the ebuild for fixes and version bumps. Just add me to metadata.xml

--

media-sound/jack-audio-connection-kit-0.118.0
media-libs/gst-plugins-base-0.10.28
media-libs/gstreamer-0.10.28
Comment 6 Angelo Arrifano (RETIRED) gentoo-dev 2010-06-25 22:33:27 UTC
And now what I should have written and forgot:

Tested on amd64
Comment 7 Mart Raudsepp gentoo-dev 2010-06-28 02:41:10 UTC
It isn't in the tree yet. I'll add it together with the bump to 0.10.19 of all the gst-plugins-bad set soon, and have you (miknix) in metadata.xml as co-maintainer then. You won't be able to do version bumps though, as all of media-libs/gst-plugins-bad and its splits (all the media-plugins/gst-plugins-* packages that inherit gst-plugins-bad eclass) have to be bumped in one go, but you can then know about any bugs filed against gst-plugins-jack specifically and help out with those.

Once gst-plugins-jack-0.10.19 is in, I'll mark this bug FIXED and hope you test the newer version at that point and let me know if there are any issues introduced. Compared to 0.10.18, 0.10.19 of gst-plugins-jack fixes a few memory leaks and implements correct multichannel support in jackaudiosrc. And a few other bug fixes.
Comment 8 Mart Raudsepp gentoo-dev 2010-08-03 03:19:29 UTC
media-plugins/gst-plugins-jack-0.10.19 is now in tree finally.
miknix is marked as a co-maintainer with a description, feel free to tweak that description, and any existing gst-plugins-jack ebuilds, but do please try to leave a notification to gstreamer@ mail alias then.
Version bumping has to be done by full gstreamer maintainers, as it's tied to 15 or more other packages, all coming from the same tarballs. After bumps, of course feel free to test the bump and notify gstreamer@ via mail or bugzilla of any troubles (e.g, that might cause to want to skip stabilization of a given version, or some such).
Comment 9 Angelo Arrifano (RETIRED) gentoo-dev 2010-08-03 09:44:31 UTC
(In reply to comment #8)
> After bumps, of
> course feel free to test the bump and notify gstreamer@ via mail or bugzilla of
> any troubles (e.g, that might cause to want to skip stabilization of a given
> version, or some such).
> 

media-libs/gstreamer-0.10.29 on the tree works without problems on amd64.
Comment 10 Florent D'halluin (Flal) 2010-12-02 18:58:19 UTC
tested on x86, would be pretty awesome to keyword/stabilize it

I have exaile playing for several minutes on jack sink and bob dylan doesn't complain yet...
Comment 11 Mart Raudsepp gentoo-dev 2010-12-20 19:49:19 UTC
*** Bug 210216 has been marked as a duplicate of this bug. ***