also fixed metadata.xml Reproducible: Always
Created attachment 235707 [details, diff] some fixes
Created attachment 235709 [details, diff] cosmetics
Created attachment 235755 [details] splitted by request
Created attachment 235761 [details, diff] 1
Created attachment 235763 [details, diff] 2
Created attachment 235765 [details, diff] 3
Created attachment 235767 [details] 4
Created attachment 235769 [details, diff] 5
Created attachment 235771 [details, diff] 6
Created attachment 235773 [details, diff] 7
Created attachment 235775 [details, diff] 8
Created attachment 235777 [details, diff] 9
Created attachment 235779 [details] 10
Created attachment 235781 [details] 11
Created attachment 235783 [details, diff] 12
Created attachment 235785 [details] 13
Created attachment 235787 [details, diff] 14
Comment on attachment 235761 [details, diff] 1 applied that part, thanks
Comment on attachment 235763 [details, diff] 2 and that one too
(In reply to comment #6) > Created an attachment (id=235765) [details] > 3 > I'm definitely not fan of this one, this is just a hack, you should go and rant upstream to see this fixed; it doesn't belong to -9999 imho
(In reply to comment #7) > Created an attachment (id=235767) [details] > 4 > - ./configure \ - --prefix=/usr \ - --libdir=/usr/$(get_libdir) \ - --shlibdir=/usr/$(get_libdir) \ - --mandir=/usr/share/man \ - --enable-static --enable-shared \ - --cc="$(tc-getCC)" \ - ${myconf} || die "configure failed" + myconf="${myconf} + --prefix=/usr + --libdir=/usr/$(get_libdir) + --shlibdir=/usr/$(get_libdir) + --mandir=/usr/share/man + --enable-shared + --cc=$(tc-getCC) + " + ./configure ${myconf} || die "configure failed" seems good but please leave --prefix, libdir etc as first arguments to ./configure; that patch makes them last. Also, how do you handle spaces in CC ? like if tc-getCC returns "distcc gcc" what happens ?
Comment on attachment 235771 [details, diff] 6 applied that one too, thanks
Comment on attachment 235773 [details, diff] 7 applied
(In reply to comment #11) > Created an attachment (id=235775) [details] > 8 > - vorbis? ( media-libs/libvorbis media-libs/libogg ) - theora? ( >=media-libs/libtheora-1.1.1[encode] media-libs/libogg ) + theora? ( + >=media-libs/libtheora-1.1.1[encode] + media-libs/libogg + ) please leave that on one line; I think it's by far more readable when there is only 2 or 3 deps. + X? ( + x11-libs/libX11 + x11-libs/libXext + sdl? ( >=media-libs/libsdl-1.2.10[audio,alsa?,oss?,video,X] ) + vaapi? ( x11-libs/libva[video_cards_nvidia?] ) + video_cards_nvidia? ( + vdpau? ( x11-libs/libvdpau ) + ) + ) This is *bad* USE="-X vaapi" will automagically link to libva if present and there will be no dep in the ebuild.
(In reply to comment #12) > Created an attachment (id=235777) [details] > 9 > sounds good but doesn't apply with the patches I've not merged :(
Comment on attachment 235783 [details, diff] 12 applied, thanks
(In reply to comment #16) > Created an attachment (id=235785) [details] > 13 > -if [ "${PV#9999}" != "${PV}" ] ; then - SCM=subversion +if [[ ${PV} == *9999* ]]; then + SCM="subversion" ESVN_REPO_URI="svn://svn.ffmpeg.org/ffmpeg/trunk" please do the opposite: replace [[ ]] by [ ${PV#...} != ... ]; this one is more standard.
Comment on attachment 235787 [details, diff] 14 as said on IRC, I really don't like this syntax and it adds nothing here; no go.
Created attachment 235849 [details, diff] 4-5 Thank you for finding mistakes :)
Created attachment 235851 [details, diff] 8
Created attachment 235853 [details, diff] 9-10
Created attachment 235855 [details, diff] 11
Created attachment 235859 [details, diff] tools forgot to do in last patch
Comment on attachment 235849 [details, diff] 4-5 applied, thanks
(In reply to comment #30) > Created an attachment (id=235851) [details] > 8 > + sdl? ( >=media-libs/libsdl-1.2.10[audio,alsa?,oss?,video,X] ) why adding those new deps? + vaapi? ( x11-libs/libva[video_cards_nvidia?] ) you certainly dont need to propagate that useflag here
(In reply to comment #32) > Created an attachment (id=235855) [details] > 11 > I'm not fond of disabling these, it has very low benefit and anyway, this can be merged only if all the reverse deps are checked and get appropriate usedeps when needed. As I told you on IRC, if you really wish to get a small ffmpeg, efforts will be much better spent by adding use expands for every single codec/muxer/etc.
>+ sdl? ( >=media-libs/libsdl-1.2.10[audio,alsa?,oss?,video,X] ) >why adding those new deps? I tested how ffplay works when libsdl is compiled without these flags: video works only when libsdl is [video,X] (may be last flag should be ',X?') sound works only when libsdl is [audio,alsa] (I do not use oss). Please also do 'cd /usr/portage && grep libsdl */*/*.ebuild' >you certainly dont need to propagate that useflag here I was not sure about that part, if you dislike it - remove.
' tools ' in IUSE can cause problems, but ' +tools ' should not, my opinion from patch №14: "Most packages (except scripts) need only libs, so installing only shared libraries is useful feature. 'tools' is not global USE and should not be in make.conf, by default ffmpeg will continue installing all binaries, this patch should not break anything."
(In reply to comment #37) > >+ sdl? ( >=media-libs/libsdl-1.2.10[audio,alsa?,oss?,video,X] ) > > >why adding those new deps? > > I tested how ffplay works when libsdl is compiled without these flags: > video works only when libsdl is [video,X] (may be last flag should be ',X?') sdl has other video outputs than X > sound works only when libsdl is [audio,alsa] (I do not use oss). I would simply make this libsdl[audio,video] then that's the point of sdl to abstract audio/video output :)
(In reply to comment #38) > ' tools ' in IUSE can cause problems, but ' +tools ' should not, my opinion > from patch №14: > "Most packages (except scripts) need only libs, so installing only shared > libraries is useful feature. > 'tools' is not global USE and should not be in make.conf, by default ffmpeg > will continue installing all binaries, this patch should not break anything." thats not how it works, use defaults just make the problem less visible; it can be disabled, ebuilds requiring it need to depend on it, period.
>I would simply make this libsdl[audio,video] then >that's the point of sdl to abstract audio/video output :) When X, alsa or oss are in make.conf only, it will work, but if you have in package.use something like 'media-video/ffmpeg -alsa oss' and media-libs/libsdl is built with alsa only, you will have no sound. However it is not normal case. Apply patch as you think will be better :) About 'tools': if it will be added as enabled by default ans -tools will be hard masked, nothing will break. The main problem is further fixing of ebuilds depending on ffmpeg.
(In reply to comment #41) > About 'tools': if it will be added as enabled by default ans -tools will be > hard masked, nothing will break. The main problem is further fixing of ebuilds > depending on ffmpeg. whats the point of having an useflag if we always force-enable it then ? INSTALL_MASK achieves the same goal.
Comment on attachment 235851 [details, diff] 8 modified version applied, thanks
Comment on attachment 235853 [details, diff] 9-10 applied, thanks
as I see no move on your side for the tools useflag I understand this as you're not willing to do the boring work for making it real, me neither, patch discarded, that bug can be closed.
