Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 324067 - sys-apps/lm_sensors: ebuild shouldn't filter compiler flag -fstack-protector
Summary: sys-apps/lm_sensors: ebuild shouldn't filter compiler flag -fstack-protector
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 07:25 UTC by cilly
Modified: 2010-06-17 08:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description cilly 2010-06-15 07:25:04 UTC
There is absolutely no reason, why in the ebuild is filtered:

filter-flags -fstack-protector

Please, remove filter-flags.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-06-16 17:31:15 UTC
@hardened: feel free to fix, falls into your category.
Comment 2 Anthony Basile gentoo-dev 2010-06-16 20:11:49 UTC
I just tested this removing filter-flags -fstack-protector from the ebuilds and encountered no problems on hardened x86 and amd64 and non-hardened x86 and amd64.

The flag was originally filtered to address bug 37421 which was triggered when compiling a 2.4 kernel and lm_sensors with gcc-3.3.2 with/without -fstack-protector set (thanks kallamej).  This is no longer an issue on current profiles.
Comment 3 cilly 2010-06-16 20:48:41 UTC
(In reply to comment #2)
> I just tested this removing filter-flags -fstack-protector from the ebuilds and
> encountered no problems on hardened x86 and amd64 and non-hardened x86 and
> amd64.
> 
> The flag was originally filtered to address bug 37421 which was triggered when
> compiling a 2.4 kernel and lm_sensors with gcc-3.3.2 with/without
> -fstack-protector set (thanks kallamej).  This is no longer an issue on current
> profiles.
> 

Tested lm_sensors without filter flag for 2.0.7 (many months) and 3.x (lately) on x86, no problems.
Comment 4 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2010-06-17 08:08:39 UTC
fixed for 3.1.2 in cvs. thanks for the report, the research and the testing.