Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 323371 - dev-ruby/json: Hardcoded modname does not work for all arches
Summary: dev-ruby/json: Hardcoded modname does not work for all arches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 OS X
: High normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 20:50 UTC by Ramon
Modified: 2010-06-12 10:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fixes hardcoded lib extensions for prefix (dev-ruby-json.patch,3.32 KB, patch)
2010-06-09 20:51 UTC, Ramon
Details | Diff
fixes hardcoded lib extensions for prefix (0001-Fixing-hardcoded-dynlib-paths-for-dev-ruby-json.patch,3.85 KB, patch)
2010-06-10 21:08 UTC, Ramon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ramon 2010-06-09 20:50:31 UTC
The ebuilds for dev-ruby/json contain newins <filename>.so statements
In prefix on macos dynamic libs have the extension .bundle hence the ebuild currently fails on macos-prefix

Please review attached patch which uses multilib.eclass to get the correct extension for the platform the ebuild is used on. I've also upgraded the keywords to ~x64-macos which is the platform I tested on

Reproducible: Always
Comment 1 Ramon 2010-06-09 20:51:32 UTC
Created attachment 234775 [details, diff]
fixes hardcoded lib extensions for prefix
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-06-09 20:56:28 UTC
Hello Ramon,

a build.log would be nice, too. Thanks for the patch ...

Michael
Comment 3 Ramon 2010-06-09 21:12:31 UTC
I don't have a failing build.log anymore, sorry

If you really really want it, I can regenerate a failing one...
Changed the subject to dev-ruby/json, patch applies to all ebuilds
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-06-10 17:24:27 UTC
Ramon, your diff is backwards. It is "diff -u <orig> <new>" - please repost.
Comment 5 Ramon 2010-06-10 21:08:16 UTC
Created attachment 234885 [details, diff]
fixes hardcoded lib extensions for prefix

crap, sorry

This is straight from my git repos, so it should be ok
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-06-10 21:12:26 UTC
@ruby team: Please accept this patch :)
Comment 7 Hans de Graaff gentoo-dev Security 2010-06-12 10:44:52 UTC
I've applied this patch to dev-ruby/json-1.4.3-r1 in CVS. Thanks!