Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 322351 - kde-base/pykde4-4.4.4 needs modified PyQt4 and a patch on arm
Summary: kde-base/pykde4-4.4.4 needs modified PyQt4 and a patch on arm
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: ARM Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard: [kde testing]
Keywords: InOverlay
Depends on: 322349
Blocks: 313999
  Show dependency tree
 
Reported: 2010-06-01 09:51 UTC by Alexander Holler
Modified: 2010-06-30 01:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from Ubuntu (make_pykde4_respect_sip_flags.diff,822 bytes, patch)
2010-06-01 09:53 UTC, Alexander Holler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Holler 2010-06-01 09:51:10 UTC
Without a modified PyQt4 and a patch for pykde4, pykde4 fails with:

--------------------------------
sipkdeuipart3.cpp: In function ‘PyObject* meth_KPlotAxis_majorTickMarks(PyObject*, PyObject*)’:
sipkdeuipart3.cpp:36826:63: error: no matching function for call to ‘QList<float>::QList(QList<double>)’
/usr/include/qt4/QtCore/qlist.h:114:12: note: candidates are: QList<T>::QList(const QList<T>&) [with T = float]
/usr/include/qt4/QtCore/qlist.h:113:12: note:                 QList<T>::QList() [with T = float]
--------------------------------

Tha patch for PyQt4 can be found in bug #322349


Reproducible: Always
Comment 1 Alexander Holler 2010-06-01 09:53:24 UTC
Created attachment 233767 [details, diff]
Patch from Ubuntu

To apply this patch (found in Ubuntus LP #308814) I've changed the following:

---------------------------
--- /usr/portage/kde-base/pykde4/pykde4-4.4.3.ebuild    2010-05-15 17:35:59.000000000 +0200
+++ pykde4-4.4.3.ebuild 2010-05-31 15:53:02.728431368 +0200
@@ -39,6 +39,7 @@
                sed -e '/^ADD_SUBDIRECTORY(examples)/s/^/# DISABLED /' -i python/${PN}/CMakeLists.txt \
                        || die "Failed to disable examples"
        fi
+    epatch "${FILESDIR}/make_pykde4_respect_sip_flags.diff"
 
        python_copy_sources
 }
---------------------------
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2010-06-06 17:08:23 UTC
Which kde version was that? Does it still apply to 4.4.4?
Comment 3 Alexander Holler 2010-06-07 08:28:32 UTC
As you can see in comment #1 this patch is for 4.4.3.

Having a look at kdebindings-4.4.4/python/pykde4/sip/kdeui/kplotaxis.sip QList<double> is still used there. So this patch and the patch for PyQt is still needed until KDE fixes this.
Comment 4 Alex Alexander (RETIRED) gentoo-dev 2010-06-15 06:43:32 UTC
This seems to be pykde4's fault, PyQt4 upstream didn't accept the patch in bug #322349.

If the patch in comment #1 fixes the issue I recommend using that.
Comment 5 Alexander Holler 2010-06-15 08:32:47 UTC
Both patches are needed, the one in comment #1 and the one for PyQt.
Comment 6 Davide Pesavento gentoo-dev 2010-06-15 10:25:58 UTC
IMHO we need a solution that doesn't require patching PyQt4.
Comment 7 Alexander Holler 2010-06-15 11:57:17 UTC
I don't see a problem in using a patch for PyQt until KDE fixes those apps who are using double instead of qreal (in conjunction with QList) and for which Python-Bindings exists.
The patch for PyQt doesn't break anything.
If someone don't want to patch PyQt, one could have a look at the bug in Launchpad, if I remember correctly, there were some patches before the one which patches PyQt.
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2010-06-15 18:03:12 UTC
Added a link to upstream bug report (see URL). Seems like this was reported already during the first kde-4.0.0 alphas...

https://bugs.kde.org/show_bug.cgi?id=176693 seems to be an upstream duplicate, too.
Comment 9 Andreas K. Hüttel archtester gentoo-dev 2010-06-16 17:55:28 UTC
Patch added in the kde overlay (it is only applied on arm). Needs testing!

(The pyqt4 patch is already in the main tree, see bug 322349.)
Comment 10 Maciej Mrozowski gentoo-dev 2010-06-30 01:09:45 UTC
Thanks for all involved.