Some wma files can cause a null pointer exception and segfault in the asfdemux of gst-plugins-ugly. This has been fixed in the later versions of gst-plugins-ugly, but 0.10.13, the latest version in Gentoo still has it. I hit this all the time and it causes amarok or totem to crash. I have a patch that fixes the issue. From cd361dfaeb79200024caf7dc88379d1fc9fb2136 Mon Sep 17 00:00:00 2001 From: Michael Banack <bob5972@gmail.com> Date: Thu, 27 May 2010 16:49:20 -0700 Subject: [PATCH] Fixed NULL Pointer Exception in gstasfdmux.c --- gst/asfdemux/gstasfdemux.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gst/asfdemux/gstasfdemux.c b/gst/asfdemux/gstasfdemux.c index 39a9f2e..cb176ee 100644 --- a/gst/asfdemux/gstasfdemux.c +++ b/gst/asfdemux/gstasfdemux.c @@ -2202,13 +2202,14 @@ gst_asf_demux_get_gst_tag_from_tag_name (const gchar * name_utf8) "WM/Year", GST_TAG_DATE} /* { "WM/Composer", GST_TAG_COMPOSER } */ }; - gsize out = strlen (name_utf8); guint i; if (name_utf8 == NULL) { GST_WARNING ("Failed to convert name to UTF8, skipping"); return NULL; } + + gsize out = strlen (name_utf8); for (i = 0; i < G_N_ELEMENTS (tags); ++i) { if (strncmp (tags[i].asf_name, name_utf8, out) == 0) { -- 1.7.1
Hello Bob, it's unlikely that the maintainer will change the stabled version, but hopefullyt, he'll take it as version bump request/argument. Thanks fir the report+patch, Michael p.s. Can you name a URL to a file that produces this error? Preferrably a creative common/... one?
Removing blocker. We can't just block stabilization of two remaining arches of the whole gstreamer set on some corner case null pointer exception in a patent encumbered audio codec. It does appear to be a regression specific to 0.10.13 though, according to my git annotate checks. Bumps of everything should be coming later this week if all goes as planned...
I don't have an example I can link to. The files I have that break are some huge web radio files in Japanese. I can't tell if they're missing tags it's expecting, corrupt, or just using a weird character set. But in any case I believe the new version fixes it. Here's a link to the upstream bug for reference. https://bugzilla.gnome.org/show_bug.cgi?id=602280 Thanks all!
gst-plugins-ugly-0.10.16 in ~arch with the referenced fix then included upstream, as I understand it. Thanks
