Bugzilla Bug 32038

When I run meld (version 0.8.3 or version 0.9.0) it gives the following
traceback:

Traceback (most recent call last):
  File "/usr/bin/meld", line 73, in ?
    meldapp.main()
  File "/usr/lib/meld/meldapp.py", line 809, in main
    app = MeldApp()
  File "/usr/lib/meld/meldapp.py", line 492, in __init__
    self.toolbar.set_style( self.prefs.get_toolbar_style() )
  File "/usr/lib/meld/meldapp.py", line 463, in get_toolbar_style
    style = {"both":gtk.TOOLBAR_BOTH, "both_horiz":gtk.TOOLBAR_BOTH_HORIZ,
KeyError: both-horiz

I thought this might be because the ebuild for dev-util/meld-.0.8.3 and
dev-util/meld-.0.9.0 (and probably dev-util/meld-.0.8.5 too) have old
dependencies.

The meld web page (http://meld.sourceforge.net/install.html) says that meld
requires:
pyorbit-1.99.6
pygtk-1.99.17
gnome-python-1.99.17

however the ebuild (at least for 0.9.0) says:
    >=dev-python/gnome-python-1.99.15
    >=dev-python/pygtk-1.99.15
    >=dev-python/pyorbit-1.99.0"

Howver I get the same problem even after upgrading to gnome-python-2.0.0,
pygtk-2.0.0 and pyorbit-2.0.0

Reproducible: Always
Steps to Reproduce:
1. emerge =dev-util/meld-0.8.3
2. meld

or

1. emerge =dev-util/meld-0.9.0
2. meld

Actual Results:  
Traceback (most recent call last):
  File "/usr/bin/meld", line 73, in ?
    meldapp.main()
  File "/usr/lib/meld/meldapp.py", line 809, in main
    app = MeldApp()
  File "/usr/lib/meld/meldapp.py", line 492, in __init__
    self.toolbar.set_style( self.prefs.get_toolbar_style() )
  File "/usr/lib/meld/meldapp.py", line 463, in get_toolbar_style
    style = {"both":gtk.TOOLBAR_BOTH, "both_horiz":gtk.TOOLBAR_BOTH_HORIZ,
KeyError: both-horiz

Expected Results:  
opened a meld window

Portage 2.0.49-r15 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1,
2.4.20-gentoo-r5)
=================================================================
System uname: 2.4.20-gentoo-r5 i686 AMD Athlon(tm)
Gentoo Base System version 1.4.3.10p1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=athlon-xp -funroll-loops -fprefetch-loop-arrays -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config
/usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O3 -march=athlon-xp -funroll-loops -fprefetch-loop-arrays -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox ccache autoaddcvs"
GENTOO_MIRRORS="http://212.219.56.162/sites/www.ibiblio.org/gentoo/
http://194.83.57.2/sites/www.ibiblio.org/gentoo/
http://194.83.57.3/sites/www.ibiblio.org/gentoo/
http://194.83.57.7/sites/www.ibiblio.org/gentoo/
http://194.83.57.11/sites/www.ibiblio.org/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 oss apm avi crypt cups encode foomaticdb gif jpeg libg++ mad mikmod
mpeg ncurses nls pdflib png quicktime spell truetype xml2 xmms xv zlib gdbm
berkdb slang readline arts tetex bonobo svga java ruby postgres X sdl gpm tcpd
pam libwww ssl perl python esd imlib oggvorbis gnome gtk motif opengl mozilla
ldap cdr alsa -kde -qt gtk2 apache2"

can't reproduce this, what gtk+ & python versions are you using ?

Im using:
gtk+-2.2.4-r1
python-2.2.3-r1

I've asked the meld author if he has any idea what's going on.
Will report here if he can think of anything.

can you try merging python, pygtk and gnome-python with less optimisations?
maybe say "-march=i686 -O2 -pipe" 

it seems like something wrong with a basic operation in python or the pygtk/gnome-python
modules.

also, what does this output?

gconftool-2 --get /desktop/gnome/interface/toolbar_style

$ gconftool-2 --get /desktop/gnome/interface/toolbar_style
both-horiz

Created an attachment (id=19888) [edit]
patch to meldapp.py, changing "both_horiz" to "both-horiz"

Sent to me by the meld author steve9000@users.sourceforge.net
It fixes the problem for me. :-)

steve9000 at users sourceforge net told me:

> Hi Duncan, it seems the spelling changed fromboth_horiz to both-horiz.
> You can manually change the line:
>
> -style = {"both":gtk.TOOLBAR_BOTH, "both_horiz":gtk.TOOLBAR_BOTH_HORIZ,
> +style = {"both":gtk.TOOLBAR_BOTH, "both-horiz":gtk.TOOLBAR_BOTH_HORIZ,

Cheers Steve.

i thought it was ok to use both for now... weird that i have the same packages
and not this problem.

this happens only when you have the toolbar settings in gnome "text beside
icons".

i've committed the patch. thanks for your report and help.

meld-0.9.0-r1 builds and works fine now
thanks guys