xbmc fails to build on my system, where media-libs/libpng-1.2.43-r2 is installed: ximapng.cpp: In member function ‘bool CxImagePNG::Decode(CxFile*)’: ximapng.cpp:145: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:147: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:155: error: ‘struct png_info_struct’ has no member named ‘trans_alpha’ ximapng.cpp:169: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:170: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:171: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp: In member function ‘bool CxImagePNG::Encode(CxFile*)’: ximapng.cpp:420: error: ‘struct png_info_struct’ has no member named ‘trans_alpha’ ximapng.cpp:421: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:422: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:423: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:424: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:425: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:425: error: ‘struct png_info_struct’ has no member named ‘trans_color’ ximapng.cpp:446: error: ‘struct png_info_struct’ has no member named ‘trans_alpha’ make[2]: *** [ximapng.o] Error 1 Seems to be due to xbmc-9.11-libpng14.patch from bug #319113 getting applied unconditionally. As net-misc/nxclient-3.4.0.7 and www-client/chromium-bin-5.0.376.0_p44230 seem to require the old libpng, I'd like to keep things this way for a while. The ebuild should handle its dependency on libpng properly. It should either depend on later libpng versions, or apply the patch conditionally. Curiously, I see no dependency on libpng in the xbmc ebuild at all. Is it transitive?
yeah, my bad. the info_ptr->trans changes are not backwards compatible. applied the patch conditionally for now, next xbmc version should sort this out for good. + 14 May 2010; Samuli Suominen <ssuominen@gentoo.org> xbmc-9.11-r3.ebuild: + Don't apply -libpng14.patch with libpng12 wrt #319721 by Martin von + Gagern.
