The fvwm has released fvwm 2.5.30. The main change from 2.5.29 is compatibility with libpng14.
Created attachment 230987 [details] fvwm-2.5.30.ebuild
Created attachment 230989 [details, diff] Patch to remove docdir cruft Patch to remove some cruft under /usr/share/doc/fvwm/
The patch attached for fvwm-2.5.30.ebuild *still* isn't addressing bug #315427.
*** Bug 314605 has been marked as a duplicate of this bug. ***
Created attachment 231415 [details] fvwm-2.5.30.ebuild Thanks, Thomas Adam. The new ebuild doesn't remove that script.
Jesús, Few things: -Since your docdir patch touches Makefile.am, you need to inherit the autotools eclass and run eautoreconf in src_prepare() - otherwise your patch has no effect on the generated configure/Makefile files. -Please test your patch with USE=doc. It isn't exactly correct. As it seems this docdir stuff is tricky. I'd suggest the following instead. First, open a request upstream for the doc/docs directory to obey ./configure --docdir=<foo>. Then, as a workaround in the ebuild do a simple "mv <old docs location> <new location>" What do you think about that?
I just went ahead and committed the simplified ebuild that I described in the last comment. Thanks.
> As it seems this docdir stuff is tricky. I'd suggest the following instead. > First, open a request upstream for the doc/docs directory to obey ./configure > --docdir=<foo>. Then, as a workaround in the ebuild do a simple "mv <old docs > location> <new location>" Keep it as a local patch -- I could apply this upstream, but there's no point.
(In reply to comment #8) > > As it seems this docdir stuff is tricky. I'd suggest the following instead. > > First, open a request upstream for the doc/docs directory to obey ./configure > > --docdir=<foo>. Then, as a workaround in the ebuild do a simple "mv <old docs > > location> <new location>" > > Keep it as a local patch -- I could apply this upstream, but there's no point. > I guess you are affiliated with upstream? I assumed it was a upstream bug that --docdir doesn't work, why do you disagree?
(In reply to comment #9) > (In reply to comment #8) > > > As it seems this docdir stuff is tricky. I'd suggest the following instead. > > > First, open a request upstream for the doc/docs directory to obey ./configure > > > --docdir=<foo>. Then, as a workaround in the ebuild do a simple "mv <old docs > > > location> <new location>" > > > > Keep it as a local patch -- I could apply this upstream, but there's no point. > > > > I guess you are affiliated with upstream? I assumed it was a upstream bug that > --docdir doesn't work, why do you disagree? I am affiliated, and docdir *does* work -- I think the problem is that you're expecting certain files to end up somewhere they're not. --docdir is supported for *generated* documentation. As in the following: ./configure --docdir=/tmp/random --enable-htmldoc && sudo make docdir=/tmp/random install Any files outside of this which you (somewhat erroneously) expect to place in $docdir is your own choosing, but I won't be applying a patch to munge this upstream, which is why I suggest you keep it local to your ebuild.
(In reply to comment #10) > I am affiliated, and docdir *does* work -- I think the problem is that you're > expecting certain files to end up somewhere they're not. --docdir is supported > for *generated* documentation. As in the following: > > ./configure --docdir=/tmp/random --enable-htmldoc && sudo make > docdir=/tmp/random install Ok. I wasn't doing "make docdir=... install". One confusing point is that regardless of --docdir setting, configure(?) outputs FVWM_DOCDIR in the summary view. I assume because of this: %% grep doc\/fvwm Makefile FVWM_DOCDIR = ${datadir}/doc/fvwm docdir = /usr/share/doc/fvwm-2.5.30 > Any files outside of this which you (somewhat erroneously) expect to place in > $docdir is your own choosing, but I won't be applying a patch to munge this > upstream, which is why I suggest you keep it local to your ebuild. Please ignore any mention of applying a patch that was proposed on this bug. I dropped that idea in comment #6 but was just doing it wrong. http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-wm/fvwm/fvwm-2.5.30.ebuild?r1=1.1&r2=1.2 Thanks for the help.
Sorry for the delay. I missed the conversation. Thanks for handling this, Jeremy. And thanks to you as well, Thomas Adam, for all your input.
