Bug 319065 – x11-misc/slim-1.3.1_p20091114: libpng-1.4 patch

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Philip Taffner 2010-05-09 15:45:30 UTC]

I wrote a little ebuild patch for slim to work with libpng-1.4.x

[Comment 1 Philip Taffner 2010-05-09 15:45:52 UTC]

Created attachment 230865 [details, diff]
libpng-1.4 ebuild patch

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2010-05-09 21:23:23 UTC]

Thanks for the patch but my understanding is that it would require an explicit dep on >=libpng-1.4 in which case it should be sent upstream as well (or some configure check for which version of libpng is available, yes?)

[Comment 3 Philip Taffner 2010-05-09 21:27:49 UTC]

With -lpng instead of -lpng12, it should work with 1.2.x and 1.4.x (I've not tested it).
So there is no explicit dep on >=libpng-1.4 or am I wrong?

[Comment 4 Jeremy Olexa (darkside) (RETIRED) 2010-05-09 21:38:07 UTC]

Ok, I can check. Give me a few days unless someone else does. :)

[Comment 5 Samuli Suominen (RETIRED) 2010-05-10 12:43:38 UTC]

+  10 May 2010; Samuli Suominen <[e-mail]>
+  slim-1.3.1_p20091114.ebuild:
+  Link to -lpng instead of -lpng12 for libpng14 to work wrt #319065 by
+  Philip Taffner.

[Comment 6 Rafael Martins (RETIRED) 2010-05-10 23:59:03 UTC]

Created attachment 231025 [details, diff]
fix libpng linkage to slim

the previous patch is a bit ugly, because slim follows searching for libpng headers at /usr/include/libpng12. My patch uses pkgconfig to find the correct cflags and libs to be linked.

[Comment 7 Jeremy Olexa (darkside) (RETIRED) 2010-05-11 00:15:46 UTC]

re-open

[Comment 8 Samuli Suominen (RETIRED) 2010-05-11 06:59:21 UTC]

applied the pkgconfig version instead, please send this to upstream.